MailJDTourDownloadDocsQualityTestsCoverage

Which source lines and branches the tests execute. Lines 91.5 %, branches 75.0 % (minimum 85 % and 72 %). main @ 399ffe3d · 21 October 2026 · pipeline 7238.

GCC Code Coverage Report

Directory: src/
Coverage: low: ≥ 0% medium: ≥ 75.0% high: ≥ 90.0%
Coverage Exec / Excl / Total
Lines: 95.6% 86 / 0 / 90
Functions: 100.0% 9 / 0 / 9
Branches: 67.7% 147 / 0 / 217
service/AuthenticatedRequest.cpp
Line Branch Exec Source
1 #include "AuthenticatedRequest.h"
2 #include "DavNetworkLimits.h"
3 #include "util/SecurityLog.h"
4 #include <QTimer>
5
6 namespace {
7 11 bool sameOrigin(const QUrl &a, const QUrl &b) {
8
3/8
✓ Branch 11 → 12 taken 7 times.
✓ Branch 11 → 16 taken 4 times.
✓ Branch 23 → 24 taken 11 times.
✗ Branch 23 → 25 not taken.
✗ Branch 37 → 38 not taken.
✗ Branch 37 → 39 not taken.
✗ Branch 41 → 42 not taken.
✗ Branch 41 → 43 not taken.
 33 return a.scheme().compare(b.scheme(), Qt::CaseInsensitive) == 0 &&
9
7/14
✓ Branch 2 → 3 taken 11 times.
✓ Branch 3 → 4 taken 11 times.
✓ Branch 5 → 6 taken 11 times.
✗ Branch 5 → 16 not taken.
✓ Branch 7 → 8 taken 11 times.
✓ Branch 9 → 10 taken 11 times.
✓ Branch 19 → 20 taken 11 times.
✗ Branch 19 → 21 not taken.
✓ Branch 21 → 22 taken 11 times.
✗ Branch 21 → 23 not taken.
✗ Branch 27 → 28 not taken.
✗ Branch 27 → 29 not taken.
✗ Branch 32 → 33 not taken.
✗ Branch 32 → 34 not taken.
 55 a.host().compare(b.host(), Qt::CaseInsensitive) == 0 &&
10
5/6
✓ Branch 12 → 13 taken 7 times.
✓ Branch 13 → 14 taken 7 times.
✓ Branch 14 → 15 taken 4 times.
✓ Branch 14 → 16 taken 3 times.
✓ Branch 17 → 18 taken 11 times.
✗ Branch 17 → 19 not taken.
 29 DavNetworkLimits::effectivePort(a) == DavNetworkLimits::effectivePort(b);
11 }
12 } // namespace
13
14 16 AuthenticatedRequest::Hop AuthenticatedRequest::nextHop(const QUrl &origin,
15 const QUrl &current, const QUrl &location, int hops) {
16 16 Hop hop;
17
1/1
✓ Branch 3 → 4 taken 16 times.
 16 hop.url = current.resolved(location);
18
11/17
✓ Branch 6 → 7 taken 16 times.
✓ Branch 7 → 8 taken 16 times.
✗ Branch 7 → 24 not taken.
✓ Branch 9 → 10 taken 16 times.
✓ Branch 11 → 12 taken 15 times.
✓ Branch 11 → 24 taken 1 time.
✓ Branch 13 → 14 taken 15 times.
✓ Branch 15 → 16 taken 14 times.
✓ Branch 15 → 24 taken 1 time.
✓ Branch 32 → 33 taken 16 times.
✗ Branch 32 → 34 not taken.
✓ Branch 34 → 35 taken 2 times.
✓ Branch 34 → 36 taken 14 times.
✗ Branch 70 → 71 not taken.
✗ Branch 70 → 72 not taken.
✗ Branch 75 → 76 not taken.
✗ Branch 75 → 77 not taken.
 46 if (!hop.url.isValid() || hop.url.host().isEmpty() || !hop.url.userInfo().isEmpty() ||
19
11/16
✓ Branch 17 → 18 taken 14 times.
✓ Branch 19 → 20 taken 9 times.
✓ Branch 19 → 25 taken 5 times.
✓ Branch 21 → 22 taken 9 times.
✗ Branch 23 → 24 not taken.
✓ Branch 23 → 25 taken 9 times.
✓ Branch 26 → 27 taken 9 times.
✓ Branch 26 → 28 taken 7 times.
✓ Branch 28 → 29 taken 14 times.
✓ Branch 28 → 30 taken 2 times.
✓ Branch 30 → 31 taken 15 times.
✓ Branch 30 → 32 taken 1 time.
✗ Branch 60 → 61 not taken.
✗ Branch 60 → 62 not taken.
✗ Branch 65 → 66 not taken.
✗ Branch 65 → 67 not taken.
 30 (hop.url.scheme() != QLatin1String("https") && hop.url.scheme() != QLatin1String("http"))) {
20 2 hop.outcome = Outcome::Network;
21
11/16
✓ Branch 37 → 38 taken 14 times.
✓ Branch 39 → 40 taken 7 times.
✓ Branch 39 → 45 taken 7 times.
✓ Branch 41 → 42 taken 7 times.
✓ Branch 43 → 44 taken 2 times.
✓ Branch 43 → 45 taken 5 times.
✓ Branch 46 → 47 taken 7 times.
✓ Branch 46 → 48 taken 7 times.
✓ Branch 48 → 49 taken 14 times.
✗ Branch 48 → 50 not taken.
✓ Branch 50 → 51 taken 2 times.
✓ Branch 50 → 52 taken 12 times.
✗ Branch 80 → 81 not taken.
✗ Branch 80 → 82 not taken.
✗ Branch 85 → 86 not taken.
✗ Branch 85 → 87 not taken.
 14 } else if (current.scheme() == QLatin1String("https") && hop.url.scheme() == QLatin1String("http")) {
22 2 hop.outcome = Outcome::InsecureRedirect;
23
2/2
✓ Branch 52 → 53 taken 1 time.
✓ Branch 52 → 54 taken 11 times.
 12 } else if (hops >= 5) {
24 1 hop.outcome = Outcome::TooManyRedirects;
25 } else {
26
1/1
✓ Branch 54 → 55 taken 11 times.
 11 hop.attachAuthorization = sameOrigin(origin, hop.url);
27
2/2
✓ Branch 55 → 56 taken 7 times.
✓ Branch 55 → 57 taken 4 times.
 11 if (!hop.attachAuthorization) hop.outcome = Outcome::RedirectedToForeignHost;
28 }
29 16 return hop;
30 ✗ }
31
32 14 AuthenticatedRequest *AuthenticatedRequest::start(QObject *owner, QNetworkAccessManager *manager,
33 QNetworkRequest request, QByteArray authorization, QByteArray body, bool post,
34 ForeignRedirect policy, Callback callback) {
35
2/5
✓ Branch 3 → 4 taken 14 times.
✗ Branch 4 → 5 not taken.
✓ Branch 4 → 6 taken 14 times.
✗ Branch 21 → 22 not taken.
✗ Branch 21 → 23 not taken.
 14 auto *operation = new AuthenticatedRequest(owner);
36 14 operation->m_manager = manager;
37
1/1
✓ Branch 7 → 8 taken 14 times.
 14 operation->m_origin = request.url();
38 14 operation->m_request = std::move(request);
39 14 operation->m_authorization = std::move(authorization);
40 14 operation->m_body = std::move(body);
41 14 operation->m_post = post;
42 14 operation->m_policy = policy;
43 14 operation->m_callback = std::move(callback);
44
1/1
✓ Branch 18 → 19 taken 14 times.
 27 QTimer::singleShot(0, operation, [operation] { operation->send(operation->m_origin, true); });
45 14 return operation;
46 }
47
48 28 AuthenticatedRequest::~AuthenticatedRequest() { cancel(); }
49
50 16 void AuthenticatedRequest::cancel() {
51 16 m_callback = {};
52
2/2
✓ Branch 4 → 5 taken 1 time.
✓ Branch 4 → 12 taken 15 times.
 16 if (m_reply) {
53 1 m_reply->disconnect(this);
54 1 m_reply->abort();
55 1 m_reply->deleteLater();
56 1 m_reply = nullptr;
57 }
58 16 m_authorization.clear();
59 16 m_body.clear();
60 16 }
61
62 18 void AuthenticatedRequest::send(const QUrl &url, bool attachAuthorization) {
63
1/2
✗ Branch 3 → 4 not taken.
✓ Branch 3 → 5 taken 18 times.
 18 if (!m_callback) return;
64
9/19
✓ Branch 6 → 7 taken 18 times.
✗ Branch 6 → 25 not taken.
✓ Branch 7 → 8 taken 18 times.
✓ Branch 8 → 9 taken 18 times.
✗ Branch 8 → 25 not taken.
✓ Branch 10 → 11 taken 18 times.
✓ Branch 12 → 13 taken 18 times.
✗ Branch 12 → 25 not taken.
✓ Branch 14 → 15 taken 18 times.
✓ Branch 16 → 17 taken 18 times.
✗ Branch 16 → 25 not taken.
✓ Branch 33 → 34 taken 18 times.
✗ Branch 33 → 35 not taken.
✗ Branch 35 → 36 not taken.
✓ Branch 35 → 40 taken 18 times.
✗ Branch 79 → 80 not taken.
✗ Branch 79 → 81 not taken.
✗ Branch 84 → 85 not taken.
✗ Branch 84 → 86 not taken.
 90 if (!m_manager || !url.isValid() || url.host().isEmpty() || !url.userInfo().isEmpty() ||
65
9/16
✓ Branch 18 → 19 taken 18 times.
✓ Branch 20 → 21 taken 6 times.
✓ Branch 20 → 26 taken 12 times.
✓ Branch 22 → 23 taken 6 times.
✗ Branch 24 → 25 not taken.
✓ Branch 24 → 26 taken 6 times.
✓ Branch 27 → 28 taken 6 times.
✓ Branch 27 → 29 taken 12 times.
✓ Branch 29 → 30 taken 18 times.
✗ Branch 29 → 31 not taken.
✓ Branch 31 → 32 taken 18 times.
✗ Branch 31 → 33 not taken.
✗ Branch 69 → 70 not taken.
✗ Branch 69 → 71 not taken.
✗ Branch 74 → 75 not taken.
✗ Branch 74 → 76 not taken.
 36 (url.scheme() != QLatin1String("http") && url.scheme() != QLatin1String("https"))) {
66 ✗ complete({Outcome::Network, {}, url}); return;
67 }
68
1/1
✓ Branch 40 → 41 taken 18 times.
 18 QNetworkRequest request = m_request;
69
1/1
✓ Branch 41 → 42 taken 18 times.
 18 request.setUrl(url);
70
1/1
✓ Branch 43 → 44 taken 18 times.
 18 request.setAttribute(QNetworkRequest::RedirectPolicyAttribute, QNetworkRequest::ManualRedirectPolicy);
71 // Never inherit a caller's raw header on a hop.
72
4/4
✓ Branch 45 → 46 taken 15 times.
✓ Branch 45 → 47 taken 3 times.
✓ Branch 48 → 49 taken 18 times.
✓ Branch 49 → 50 taken 18 times.
 18 request.setRawHeader("Authorization", attachAuthorization ? m_authorization : QByteArray());
73
5/5
✓ Branch 52 → 53 taken 1 time.
✓ Branch 52 → 56 taken 17 times.
✓ Branch 54 → 55 taken 1 time.
✓ Branch 57 → 58 taken 17 times.
✓ Branch 59 → 60 taken 18 times.
 18 m_reply = m_post ? m_manager->post(request, m_body) : m_manager->get(request);
74
1/1
✓ Branch 61 → 62 taken 18 times.
 18 DavNetworkLimits::apply(m_reply);
75
1/1
✓ Branch 63 → 64 taken 18 times.
 18 connect(m_reply, &QNetworkReply::finished, this, &AuthenticatedRequest::finished);
76 18 }
77
78 17 void AuthenticatedRequest::finished() {
79 17 QNetworkReply *reply = m_reply;
80
1/2
✗ Branch 3 → 4 not taken.
✓ Branch 3 → 5 taken 17 times.
 24 if (!reply) return;
81
1/1
✓ Branch 5 → 6 taken 17 times.
 17 m_reply = nullptr;
82
1/1
✓ Branch 6 → 7 taken 17 times.
 17 reply->deleteLater();
83
2/2
✓ Branch 7 → 8 taken 17 times.
✓ Branch 8 → 9 taken 17 times.
 17 const int status = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
84
1/1
✓ Branch 10 → 11 taken 17 times.
 17 const QString limit = DavNetworkLimits::failureReason(reply);
85
2/2
✓ Branch 11 → 12 taken 17 times.
✓ Branch 12 → 13 taken 17 times.
 17 const QUrl location = reply->attribute(QNetworkRequest::RedirectionTargetAttribute).toUrl();
86
1/2
✗ Branch 15 → 16 not taken.
✓ Branch 15 → 21 taken 17 times.
 17 if (!limit.isEmpty()) { complete({Outcome::Limit, {}, reply->url(), status, limit, m_leftOrigin}); return; }
87
7/15
✓ Branch 21 → 22 taken 17 times.
✓ Branch 22 → 23 taken 7 times.
✓ Branch 22 → 29 taken 10 times.
✓ Branch 23 → 24 taken 7 times.
✗ Branch 23 → 28 not taken.
✗ Branch 24 → 25 not taken.
✓ Branch 24 → 28 taken 7 times.
✗ Branch 25 → 26 not taken.
✗ Branch 25 → 28 not taken.
✗ Branch 26 → 27 not taken.
✗ Branch 26 → 28 not taken.
✗ Branch 27 → 28 not taken.
✗ Branch 27 → 29 not taken.
✓ Branch 30 → 31 taken 7 times.
✓ Branch 30 → 75 taken 10 times.
 17 if (!location.isEmpty() && (status == 301 || status == 302 || status == 303 || status == 307 || status == 308)) {
88
2/2
✓ Branch 31 → 32 taken 7 times.
✓ Branch 32 → 33 taken 7 times.
 7 const Hop hop = nextHop(m_origin, reply->url(), location, m_hops);
89
2/2
✓ Branch 34 → 35 taken 5 times.
✓ Branch 34 → 66 taken 2 times.
 7 if (hop.outcome != Outcome::Ok &&
90
3/4
✓ Branch 35 → 36 taken 5 times.
✗ Branch 35 → 37 not taken.
✓ Branch 36 → 37 taken 2 times.
✓ Branch 36 → 66 taken 3 times.
 5 !(hop.outcome == Outcome::RedirectedToForeignHost && m_policy == ForeignRedirect::FollowWithoutCredentials)) {
91
6/6
✓ Branch 37 → 38 taken 2 times.
✓ Branch 41 → 42 taken 2 times.
✓ Branch 42 → 43 taken 2 times.
✓ Branch 43 → 44 taken 2 times.
✓ Branch 47 → 39 taken 2 times.
✓ Branch 47 → 48 taken 2 times.
 4 qCWarning(lcSecurity) << "Authenticated redirect refused" << int(hop.outcome);
92
7/7
✓ Branch 48 → 49 taken 2 times.
✓ Branch 52 → 53 taken 2 times.
✓ Branch 53 → 54 taken 2 times.
✓ Branch 55 → 56 taken 2 times.
✓ Branch 56 → 57 taken 2 times.
✓ Branch 61 → 50 taken 2 times.
✓ Branch 61 → 62 taken 2 times.
 4 qCDebug(lcSecurity) << "Redirect target host" << hop.url.host();
93 2 complete({hop.outcome, {}, hop.url, status, {}, m_leftOrigin}); return;
94 }
95 5 ++m_hops;
96 5 m_leftOrigin |= !hop.attachAuthorization;
97
4/8
✓ Branch 66 → 67 taken 5 times.
✗ Branch 66 → 70 not taken.
✓ Branch 67 → 68 taken 5 times.
✗ Branch 67 → 69 not taken.
✓ Branch 68 → 69 taken 5 times.
✗ Branch 68 → 71 not taken.
✗ Branch 69 → 70 not taken.
✓ Branch 69 → 71 taken 5 times.
 5 if (status == 303 || ((status == 301 || status == 302) && m_post)) {
98 ✗ m_post = false;
99 ✗ m_body.clear();
100 }
101
1/1
✓ Branch 71 → 72 taken 5 times.
 5 send(hop.url, hop.attachAuthorization);
102 5 return;
103 7 }
104
3/4
✓ Branch 75 → 76 taken 9 times.
✓ Branch 75 → 84 taken 1 time.
✓ Branch 76 → 77 taken 9 times.
✗ Branch 76 → 84 not taken.
 19 const Outcome outcome = status == 401 || status == 403 ? Outcome::Unauthorized
105
5/7
✓ Branch 77 → 78 taken 9 times.
✓ Branch 78 → 79 taken 8 times.
✓ Branch 78 → 82 taken 1 time.
✓ Branch 79 → 80 taken 8 times.
✗ Branch 79 → 82 not taken.
✓ Branch 80 → 81 taken 8 times.
✗ Branch 80 → 82 not taken.
 9 : reply->error() == QNetworkReply::NoError && status >= 200 && status < 300 ? Outcome::Ok : Outcome::Network;
106 10 complete({outcome, outcome == Outcome::Ok ? reply->readAll() : QByteArray(), reply->url(), status, {}, m_leftOrigin});
107 36 }
108
109 12 void AuthenticatedRequest::complete(Result result) {
110
1/2
✗ Branch 3 → 4 not taken.
✓ Branch 3 → 5 taken 12 times.
 12 if (!m_callback) return;
111 12 Callback callback = std::move(m_callback);
112
2/2
✓ Branch 7 → 8 taken 12 times.
✓ Branch 8 → 9 taken 12 times.
 12 m_authorization.clear(); m_body.clear();
113
1/1
✓ Branch 9 → 10 taken 12 times.
 12 deleteLater();
114
1/1
✓ Branch 12 → 13 taken 12 times.
 12 callback(std::move(result));
115 12 }
116