MailJDTourDownloadDocsQualityTestsCoverage

Which source lines and branches the tests execute. Lines 91.5 %, branches 75.0 % (minimum 85 % and 72 %). main @ 399ffe3d · 21 October 2026 · pipeline 7238.

GCC Code Coverage Report

Directory: src/
Coverage: low: ≥ 0% medium: ≥ 75.0% high: ≥ 90.0%
Coverage Exec / Excl / Total
Lines: 88.2% 120 / 0 / 136
Functions: 100.0% 11 / 0 / 11
Branches: 74.8% 160 / 0 / 214
app/core/CalendarSyncApply.cpp
Line Branch Exec Source
1 #include "CalendarSyncApply.h"
2
3 #include "data/CalendarStore.h"
4 #include "service/CalDavClient.h"
5
6 #include <QLoggingCategory>
7 #include <QSet>
8
9
4/7
✓ Branch 2 → 3 taken 4 times.
✓ Branch 2 → 8 taken 162 times.
✓ Branch 4 → 5 taken 4 times.
✗ Branch 4 → 8 not taken.
✓ Branch 5 → 6 taken 4 times.
✗ Branch 10 → 11 not taken.
✗ Branch 10 → 12 not taken.
 166 Q_LOGGING_CATEGORY(lcCalendarApply, "mailjd.calendarsync.apply")
10
11 namespace {
12 template <typename Item>
13 344 bool allInCollection(const QList<Item> &items, const QString &path) {
14
4/4
bool (anonymous namespace)::allInCollection<CalendarTask>(QList<CalendarTask> const&, QString const&):
✓ Branch 10 → 4 taken 7 times.
✓ Branch 10 → 11 taken 172 times.
bool (anonymous namespace)::allInCollection<CalendarEvent>(QList<CalendarEvent> const&, QString const&):
✓ Branch 10 → 4 taken 443 times.
✓ Branch 10 → 11 taken 172 times.
 794 for (const auto &item : items)
15
2/4
bool (anonymous namespace)::allInCollection<CalendarTask>(QList<CalendarTask> const&, QString const&):
✗ Branch 6 → 7 not taken.
✓ Branch 6 → 8 taken 7 times.
bool (anonymous namespace)::allInCollection<CalendarEvent>(QList<CalendarEvent> const&, QString const&):
✗ Branch 6 → 7 not taken.
✓ Branch 6 → 8 taken 443 times.
 450 if (item.calendarPath != path) return false;
16 344 return true;
17 }
18 } // namespace
19
20 169 QString CalendarSyncApply::nextRequestToken(const QString &accountId, const QString &path) const {
21
1/1
✓ Branch 2 → 3 taken 169 times.
 169 const auto enumeration = m_store->enumerationState(accountId, path);
22
2/2
✓ Branch 3 → 4 taken 1 time.
✓ Branch 3 → 5 taken 168 times.
 169 if (enumeration.active)
23 1 return enumeration.token; // "" restarts an enumeration that never checkpointed
24
1/1
✓ Branch 5 → 6 taken 168 times.
 168 return m_store->calendarSyncToken(accountId, path);
25 169 }
26
27 // Changed resources replace every row of their UID, so exceptions removed
28 // on the server disappear as well.
29 171 bool CalendarSyncApply::writeEvents(const QString &accountId, const QString &path,
30 const QList<CalendarEvent> &events, const QStringList &queued,
31 int *applied) {
32 171 QSet<QString> replaced;
33
2/2
✓ Branch 30 → 5 taken 443 times.
✓ Branch 30 → 31 taken 171 times.
 614 for (const auto &event : events) {
34
2/2
✓ Branch 7 → 8 taken 2 times.
✓ Branch 7 → 9 taken 441 times.
 443 if (queued.contains(event.uid)) continue;
35
1/2
✓ Branch 10 → 11 taken 441 times.
✗ Branch 10 → 16 not taken.
 441 if (!replaced.contains(event.uid)) {
36
1/1
✓ Branch 12 → 13 taken 441 times.
 441 m_store->deleteEvent(event.uid, accountId, path); // false = no previous row
37
1/1
✓ Branch 14 → 15 taken 441 times.
 441 replaced.insert(event.uid);
38 441 ++*applied;
39 }
40 441 CalendarEvent stored = event;
41 441 stored.accountId = accountId;
42
2/3
✓ Branch 18 → 19 taken 441 times.
✗ Branch 19 → 20 not taken.
✓ Branch 19 → 21 taken 441 times.
 441 if (!m_store->upsertEvent(stored)) return false;
43 441 }
44 171 return true;
45 171 }
46
47 171 bool CalendarSyncApply::writeTasks(const QString &accountId, const QString &path,
48 const QList<CalendarTask> &tasks, const QStringList &queued,
49 int *applied) {
50 Q_UNUSED(path);
51
2/2
✓ Branch 22 → 4 taken 7 times.
✓ Branch 22 → 23 taken 170 times.
 177 for (const auto &task : tasks) {
52
1/2
✗ Branch 6 → 7 not taken.
✓ Branch 6 → 8 taken 7 times.
 7 if (queued.contains(task.uid)) continue;
53 7 CalendarTask stored = task;
54 7 stored.accountId = accountId;
55
3/3
✓ Branch 10 → 11 taken 7 times.
✓ Branch 11 → 12 taken 1 time.
✓ Branch 11 → 13 taken 6 times.
 7 if (!m_store->upsertTask(stored)) return false;
56 6 ++*applied;
57 7 }
58 170 return true;
59 }
60
61 166 bool CalendarSyncApply::writePage(const QString &accountId, const QString &path,
62 const DavCollectionChanges &changes, bool enumeration,
63 const QString &ctag, PageOutcome *outcome) {
64
5/7
✓ Branch 3 → 4 taken 107 times.
✓ Branch 3 → 7 taken 59 times.
✓ Branch 4 → 5 taken 107 times.
✗ Branch 5 → 6 not taken.
✓ Branch 5 → 7 taken 107 times.
✗ Branch 8 → 9 not taken.
✓ Branch 8 → 10 taken 166 times.
 166 if (changes.requestToken.isEmpty() && !m_store->beginEnumeration(accountId, path)) return false;
65
1/1
✓ Branch 10 → 11 taken 166 times.
 166 const QStringList queued = m_store->outboxUids(accountId, path);
66
2/2
✓ Branch 25 → 13 taken 6 times.
✓ Branch 25 → 26 taken 166 times.
 172 for (const auto &href : changes.removedHrefs) {
67
2/3
✓ Branch 14 → 15 taken 6 times.
✗ Branch 17 → 18 not taken.
✓ Branch 17 → 19 taken 6 times.
 6 if (queued.contains(m_store->uidForHref(accountId, path, href))) continue;
68
2/3
✓ Branch 19 → 20 taken 6 times.
✗ Branch 20 → 21 not taken.
✓ Branch 20 → 22 taken 6 times.
 6 if (!m_store->removeHref(accountId, path, href)) return false;
69 6 ++outcome->appliedResources;
70 }
71
4/5
✓ Branch 26 → 28 taken 166 times.
✓ Branch 28 → 29 taken 166 times.
✗ Branch 28 → 31 not taken.
✓ Branch 33 → 34 taken 1 time.
✓ Branch 33 → 35 taken 165 times.
 332 if (!writeEvents(accountId, path, changes.events, queued, &outcome->appliedResources) ||
72
3/3
✓ Branch 29 → 30 taken 166 times.
✓ Branch 30 → 31 taken 1 time.
✓ Branch 30 → 32 taken 165 times.
 166 !writeTasks(accountId, path, changes.tasks, queued, &outcome->appliedResources))
73 1 return false;
74
2/2
✓ Branch 35 → 36 taken 109 times.
✓ Branch 35 → 59 taken 56 times.
 165 if (enumeration) {
75 109 QStringList seen;
76
3/3
✓ Branch 39 → 40 taken 422 times.
✓ Branch 42 → 38 taken 422 times.
✓ Branch 42 → 43 taken 109 times.
 531 for (const auto &event : changes.events) seen << event.uid;
77
3/3
✓ Branch 46 → 47 taken 3 times.
✓ Branch 49 → 45 taken 3 times.
✓ Branch 49 → 50 taken 109 times.
 112 for (const auto &task : changes.tasks) seen << task.uid;
78
2/3
✓ Branch 50 → 51 taken 109 times.
✗ Branch 51 → 52 not taken.
✓ Branch 51 → 53 taken 109 times.
 109 if (!m_store->addEnumerationSeen(accountId, path, seen)) return false;
79 109 }
80
2/2
✓ Branch 60 → 61 taken 1 time.
✓ Branch 60 → 72 taken 164 times.
 165 if (!changes.failedHrefs.isEmpty()) {
81 // Applied, but the members in error must come again: no token moves.
82 1 outcome->result = PageResult::Failed;
83
1/1
✓ Branch 66 → 67 taken 1 time.
 2 outcome->error = QStringLiteral("%1 resource(s) returned without data").arg(changes.failedHrefs.size());
84 1 return true;
85 }
86
2/2
✓ Branch 72 → 73 taken 3 times.
✓ Branch 72 → 80 taken 161 times.
 164 if (changes.truncated) {
87
2/3
✓ Branch 73 → 74 taken 3 times.
✗ Branch 73 → 76 not taken.
✓ Branch 74 → 75 taken 3 times.
 3 const bool stored = enumeration ? m_store->setEnumerationCheckpoint(accountId, path, changes.syncToken)
88 ✗ : m_store->setCalendarSyncToken(accountId, path, changes.syncToken);
89 3 outcome->result = PageResult::Continue;
90 3 outcome->continueToken = changes.syncToken;
91 3 return stored;
92 }
93 // F-59 (SPRINT-104): completeness — this page is final (not truncated,
94 // no failed members; both branches above returned already), so an empty
95 // enumeration prunes as a genuinely empty collection.
96
5/7
✓ Branch 80 → 81 taken 105 times.
✓ Branch 80 → 85 taken 56 times.
✓ Branch 82 → 83 taken 105 times.
✗ Branch 83 → 84 not taken.
✓ Branch 83 → 85 taken 105 times.
✗ Branch 86 → 87 not taken.
✓ Branch 86 → 88 taken 161 times.
 161 if (enumeration && !m_store->finishEnumeration(accountId, path, queued, changes.failedHrefs.isEmpty()))
97 ✗ return false;
98
2/3
✓ Branch 88 → 89 taken 161 times.
✗ Branch 89 → 90 not taken.
✓ Branch 89 → 91 taken 161 times.
 161 if (!m_store->setCalendarSyncToken(accountId, path, changes.syncToken)) return false;
99
5/7
✓ Branch 92 → 93 taken 100 times.
✓ Branch 92 → 96 taken 61 times.
✓ Branch 93 → 94 taken 100 times.
✗ Branch 94 → 95 not taken.
✓ Branch 94 → 96 taken 100 times.
✗ Branch 97 → 98 not taken.
✓ Branch 97 → 99 taken 161 times.
 161 if (!ctag.isEmpty() && !m_store->setCalendarCtag(accountId, path, ctag)) return false;
100 161 outcome->result = PageResult::Committed;
101 161 return true;
102 166 }
103
104 167 CalendarSyncApply::PageOutcome CalendarSyncApply::applySyncPage(const QString &accountId,
105 const QString &path,
106 const DavCollectionChanges &changes,
107 const QString &ctag) {
108 167 PageOutcome outcome;
109
3/6
✓ Branch 3 → 4 taken 167 times.
✗ Branch 3 → 6 not taken.
✗ Branch 5 → 6 not taken.
✓ Branch 5 → 7 taken 167 times.
✗ Branch 8 → 9 not taken.
✓ Branch 8 → 17 taken 167 times.
 167 if (!allInCollection(changes.events, path) || !allInCollection(changes.tasks, path)) {
110 ✗ outcome.error = QStringLiteral("response does not belong to the requested collection");
111 ✗ return outcome;
112 }
113 // A repeated token without any change cannot make progress (endless loop).
114
4/6
✓ Branch 19 → 20 taken 1 time.
✓ Branch 19 → 27 taken 3 times.
✓ Branch 21 → 22 taken 1 time.
✗ Branch 21 → 27 not taken.
✓ Branch 23 → 24 taken 1 time.
✗ Branch 23 → 27 not taken.
 5 if (changes.truncated && changes.syncToken == changes.requestToken && changes.events.isEmpty() &&
115
5/6
✓ Branch 17 → 18 taken 4 times.
✓ Branch 17 → 27 taken 163 times.
✓ Branch 25 → 26 taken 1 time.
✗ Branch 25 → 27 not taken.
✓ Branch 28 → 29 taken 1 time.
✓ Branch 28 → 37 taken 166 times.
 172 changes.tasks.isEmpty() && changes.removedHrefs.isEmpty()) {
116 1 outcome.error = QStringLiteral("truncated sync-collection made no progress");
117 1 return outcome;
118 }
119
1/1
✓ Branch 37 → 38 taken 166 times.
 166 const auto state = m_store->enumerationState(accountId, path);
120
2/2
✓ Branch 39 → 40 taken 59 times.
✓ Branch 39 → 43 taken 107 times.
 225 const bool enumeration = changes.requestToken.isEmpty() ||
121
3/4
✓ Branch 40 → 41 taken 2 times.
✓ Branch 40 → 44 taken 57 times.
✓ Branch 42 → 43 taken 2 times.
✗ Branch 42 → 44 not taken.
 59 (state.active && state.token == changes.requestToken);
122
2/3
✓ Branch 45 → 46 taken 166 times.
✗ Branch 46 → 47 not taken.
✓ Branch 46 → 55 taken 166 times.
 166 if (!m_store->beginTransaction()) {
123 ✗ outcome.error = QStringLiteral("could not start the store transaction");
124 ✗ outcome.localFailure = true;
125 ✗ return outcome;
126 }
127 166 PageOutcome written;
128
3/3
✓ Branch 55 → 56 taken 166 times.
✓ Branch 56 → 57 taken 1 time.
✓ Branch 56 → 78 taken 165 times.
 166 if (!writePage(accountId, path, changes, enumeration, ctag, &written)) {
129
1/1
✓ Branch 57 → 58 taken 1 time.
 1 m_store->rollbackTransaction();
130 1 outcome.error = QStringLiteral("local store write failed; nothing applied");
131 1 outcome.localFailure = true;
132
7/7
✓ Branch 64 → 65 taken 1 time.
✓ Branch 68 → 69 taken 1 time.
✓ Branch 69 → 70 taken 1 time.
✓ Branch 70 → 71 taken 1 time.
✓ Branch 71 → 72 taken 1 time.
✓ Branch 75 → 66 taken 1 time.
✓ Branch 75 → 76 taken 1 time.
 2 qCWarning(lcCalendarApply) << "sync page rolled back for" << accountId << path;
133 1 return outcome;
134 }
135
2/3
✓ Branch 78 → 79 taken 165 times.
✗ Branch 79 → 80 not taken.
✓ Branch 79 → 88 taken 165 times.
 165 if (!m_store->commitTransaction()) {
136 ✗ outcome.error = QStringLiteral("local store commit failed; nothing applied");
137 ✗ outcome.localFailure = true;
138 ✗ return outcome;
139 }
140
10/10
✓ Branch 88 → 89 taken 165 times.
✓ Branch 92 → 93 taken 165 times.
✓ Branch 93 → 94 taken 165 times.
✓ Branch 94 → 95 taken 165 times.
✓ Branch 95 → 96 taken 165 times.
✓ Branch 96 → 97 taken 109 times.
✓ Branch 96 → 98 taken 56 times.
✓ Branch 99 → 100 taken 165 times.
✓ Branch 107 → 90 taken 165 times.
✓ Branch 107 → 108 taken 165 times.
 330 qCInfo(lcCalendarApply) << "sync page" << accountId << path << (enumeration ? "enumeration" : "delta")
141
2/2
✓ Branch 100 → 101 taken 165 times.
✓ Branch 101 → 102 taken 165 times.
 165 << "applied" << written.appliedResources
142
2/2
✓ Branch 102 → 103 taken 165 times.
✓ Branch 103 → 104 taken 165 times.
 165 << "result" << static_cast<int>(written.result);
143 165 return written;
144 167 }
145
146 5 bool CalendarSyncApply::applyQueryEvents(const QString &accountId, const QString &path,
147 const QList<CalendarEvent> &events, bool complete) {
148
4/7
✓ Branch 3 → 4 taken 5 times.
✗ Branch 3 → 6 not taken.
✓ Branch 4 → 5 taken 5 times.
✗ Branch 5 → 6 not taken.
✓ Branch 5 → 7 taken 5 times.
✗ Branch 8 → 9 not taken.
✓ Branch 8 → 10 taken 5 times.
 5 if (!allInCollection(events, path) || !m_store->beginTransaction()) return false;
149
1/1
✓ Branch 10 → 11 taken 5 times.
 5 const QStringList queued = m_store->outboxUids(accountId, path);
150 5 int applied = 0;
151 5 QStringList uids = queued;
152
3/3
✓ Branch 15 → 16 taken 5 times.
✓ Branch 18 → 14 taken 5 times.
✓ Branch 18 → 19 taken 5 times.
 10 for (const auto &event : events) uids << event.uid;
153 // S106-054: like F-59 for sync-collection, a COMPLETE query answer is the
154 // whole collection — also when it is empty (allowEmpty). It used to prune
155 // nothing while the caller committed the CTag, so server-side deletions
156 // stayed forever on query-only servers. Queued local changes stay (uids).
157
2/3
✓ Branch 19 → 20 taken 5 times.
✓ Branch 20 → 21 taken 5 times.
✗ Branch 20 → 25 not taken.
 10 const bool ok = writeEvents(accountId, path, events, queued, &applied) &&
158
4/5
✓ Branch 21 → 22 taken 4 times.
✓ Branch 21 → 24 taken 1 time.
✓ Branch 22 → 23 taken 4 times.
✓ Branch 23 → 24 taken 4 times.
✗ Branch 23 → 25 not taken.
 5 (!complete || m_store->removeStaleEvents(accountId, path, uids, /*allowEmpty=*/true));
159
1/2
✗ Branch 26 → 27 not taken.
✓ Branch 26 → 29 taken 5 times.
 5 if (!ok) {
160 ✗ m_store->rollbackTransaction();
161 ✗ return false;
162 }
163
1/1
✓ Branch 29 → 30 taken 5 times.
 5 return m_store->commitTransaction();
164 5 }
165
166 5 bool CalendarSyncApply::applyQueryTasks(const QString &accountId, const QString &path,
167 const QList<CalendarTask> &tasks, bool complete) {
168
4/7
✓ Branch 3 → 4 taken 5 times.
✗ Branch 3 → 6 not taken.
✓ Branch 4 → 5 taken 5 times.
✗ Branch 5 → 6 not taken.
✓ Branch 5 → 7 taken 5 times.
✗ Branch 8 → 9 not taken.
✓ Branch 8 → 10 taken 5 times.
 5 if (!allInCollection(tasks, path) || !m_store->beginTransaction()) return false;
169
1/1
✓ Branch 10 → 11 taken 5 times.
 5 const QStringList queued = m_store->outboxUids(accountId, path);
170 5 int applied = 0;
171 5 QStringList uids = queued;
172
1/3
✗ Branch 15 → 16 not taken.
✗ Branch 18 → 14 not taken.
✓ Branch 18 → 19 taken 5 times.
 5 for (const auto &task : tasks) uids << task.uid;
173
2/3
✓ Branch 19 → 20 taken 5 times.
✓ Branch 20 → 21 taken 5 times.
✗ Branch 20 → 25 not taken.
 10 const bool ok = writeTasks(accountId, path, tasks, queued, &applied) &&
174
3/5
✓ Branch 21 → 22 taken 5 times.
✗ Branch 21 → 24 not taken.
✓ Branch 22 → 23 taken 5 times.
✓ Branch 23 → 24 taken 5 times.
✗ Branch 23 → 25 not taken.
 5 (!complete || m_store->removeStaleTasks(accountId, path, uids, /*allowEmpty=*/true));
175
1/2
✗ Branch 26 → 27 not taken.
✓ Branch 26 → 29 taken 5 times.
 5 if (!ok) {
176 ✗ m_store->rollbackTransaction();
177 ✗ return false;
178 }
179
1/1
✓ Branch 29 → 30 taken 5 times.
 5 return m_store->commitTransaction();
180 5 }
181
182 3 bool CalendarSyncApply::resetCollectionToken(const QString &accountId, const QString &path) {
183
1/2
✗ Branch 3 → 4 not taken.
✓ Branch 3 → 5 taken 3 times.
 3 if (!m_store->beginTransaction()) return false;
184
4/9
✓ Branch 6 → 7 taken 3 times.
✓ Branch 7 → 8 taken 3 times.
✗ Branch 7 → 10 not taken.
✓ Branch 12 → 13 taken 3 times.
✗ Branch 12 → 14 not taken.
✗ Branch 14 → 15 not taken.
✓ Branch 14 → 17 taken 3 times.
✗ Branch 20 → 21 not taken.
✗ Branch 20 → 22 not taken.
 6 if (!m_store->setCalendarSyncToken(accountId, path, QString()) ||
185
2/3
✓ Branch 8 → 9 taken 3 times.
✗ Branch 9 → 10 not taken.
✓ Branch 9 → 11 taken 3 times.
 3 !m_store->abandonEnumeration(accountId, path)) {
186 ✗ m_store->rollbackTransaction();
187 ✗ return false;
188 }
189 3 return m_store->commitTransaction();
190 }
191