presentation/CommandCorrection.cpp
| Line | Branch | Exec | Source |
|---|---|---|---|
| 1 | // "Did you mean" of the command bar (S98.4.8), split from | ||
| 2 | // CommandCompletion.cpp: the closest command line for an unknown or | ||
| 3 | // misspelled one. Typed text is never logged (rule 11). | ||
| 4 | |||
| 5 | #include "CommandCompletion.h" | ||
| 6 | |||
| 7 | #include "app/NamedCommandCatalog.h" | ||
| 8 | #include <algorithm> | ||
| 9 | #include <limits> | ||
| 10 | |||
| 11 | namespace CommandCompletion { | ||
| 12 | namespace { | ||
| 13 | |||
| 14 |
2/2✓ Branch 3 → 4 taken 9 times.
✓ Branch 3 → 5 taken 21 times.
|
30 | int allowedDistance(const QString &word) { return word.size() <= 4 ? 1 : 2; } |
| 15 | |||
| 16 | // The value of `spec` closest to a misspelled `word` ("unred" → "unread"); | ||
| 17 | // "" when `word` is a value already or nothing is close enough. | ||
| 18 | 8 | QString nearestValue(const NamedCommandSpec &spec, const QString &word) { | |
| 19 | 8 | QString best; | |
| 20 | 8 | int bestDistance = allowedDistance(word) + 1; | |
| 21 |
2/2✓ Branch 20 → 5 taken 26 times.
✓ Branch 20 → 21 taken 5 times.
|
31 | for (const auto &value : spec.values) { |
| 22 |
2/2✓ Branch 7 → 8 taken 26 times.
✓ Branch 8 → 9 taken 26 times.
|
26 | const int distance = editDistance(word, QString::fromLatin1(value.word)); |
| 23 |
2/2✓ Branch 10 → 11 taken 3 times.
✓ Branch 10 → 12 taken 23 times.
|
26 | if (distance == 0) return {}; |
| 24 |
2/2✓ Branch 12 → 13 taken 5 times.
✓ Branch 12 → 18 taken 18 times.
|
23 | if (distance < bestDistance) { |
| 25 |
1/1✓ Branch 14 → 15 taken 5 times.
|
5 | best = QString::fromLatin1(value.word); |
| 26 | 5 | bestDistance = distance; | |
| 27 | } | ||
| 28 | } | ||
| 29 | 5 | return best; | |
| 30 | 8 | } | |
| 31 | |||
| 32 | // A known command with misspelled values: the first word of its argument, | ||
| 33 | // every word of a command with several values (D-15a: "mark read imprtant"). | ||
| 34 | 6 | QString correctValues(const NamedCommandSpec &spec, const QString &argument) { | |
| 35 | 6 | QStringList words; | |
| 36 | 6 | qsizetype at = 0; | |
| 37 | 6 | bool changed = false; | |
| 38 |
2/2✓ Branch 2 → 3 taken 4 times.
✓ Branch 2 → 4 taken 2 times.
|
6 | const qsizetype limit = spec.several ? std::numeric_limits<qsizetype>::max() : 1; |
| 39 |
2/2✓ Branch 45 → 6 taken 13 times.
✓ Branch 45 → 46 taken 1 time.
|
14 | while (words.size() < limit) { |
| 40 |
6/6✓ Branch 9 → 10 taken 11 times.
✓ Branch 9 → 14 taken 5 times.
✓ Branch 12 → 13 taken 3 times.
✓ Branch 12 → 14 taken 8 times.
✓ Branch 15 → 7 taken 3 times.
✓ Branch 15 → 16 taken 13 times.
|
16 | while (at < argument.size() && argument.at(at).isSpace()) ++at; |
| 41 |
2/2✓ Branch 17 → 18 taken 5 times.
✓ Branch 17 → 19 taken 8 times.
|
13 | if (at >= argument.size()) break; |
| 42 | 8 | qsizetype end = at; | |
| 43 |
6/6✓ Branch 22 → 23 taken 51 times.
✓ Branch 22 → 27 taken 4 times.
✓ Branch 25 → 26 taken 47 times.
✓ Branch 25 → 27 taken 4 times.
✓ Branch 28 → 20 taken 47 times.
✓ Branch 28 → 29 taken 8 times.
|
55 | while (end < argument.size() && !argument.at(end).isSpace()) ++end; |
| 44 |
1/1✓ Branch 29 → 30 taken 8 times.
|
8 | const QString word = argument.mid(at, end - at); |
| 45 |
1/1✓ Branch 30 → 31 taken 8 times.
|
8 | const QString near = nearestValue(spec, word); |
| 46 |
4/4✓ Branch 31 → 32 taken 7 times.
✓ Branch 31 → 34 taken 1 time.
✓ Branch 33 → 34 taken 4 times.
✓ Branch 33 → 35 taken 3 times.
|
8 | changed = changed || !near.isEmpty(); |
| 47 |
3/3✓ Branch 37 → 38 taken 3 times.
✓ Branch 37 → 39 taken 5 times.
✓ Branch 40 → 41 taken 8 times.
|
8 | words << (near.isEmpty() ? word : near); |
| 48 | 8 | at = end; | |
| 49 | 8 | } | |
| 50 |
2/2✓ Branch 46 → 47 taken 2 times.
✓ Branch 46 → 48 taken 4 times.
|
6 | if (!changed) return {}; |
| 51 |
2/2✓ Branch 48 → 49 taken 4 times.
✓ Branch 49 → 50 taken 4 times.
|
4 | const QString tail = argument.mid(at).trimmed(); |
| 52 |
7/7✓ Branch 52 → 53 taken 3 times.
✓ Branch 52 → 54 taken 1 time.
✓ Branch 56 → 57 taken 1 time.
✓ Branch 59 → 60 taken 4 times.
✓ Branch 62 → 63 taken 4 times.
✓ Branch 63 → 64 taken 4 times.
✓ Branch 64 → 65 taken 4 times.
|
4 | return spec.name + QLatin1Char(' ') + words.join(QLatin1Char(' ')) + (tail.isEmpty() ? QString{} : QLatin1Char(' ') + tail); |
| 53 | 6 | } | |
| 54 | |||
| 55 | } // namespace | ||
| 56 | |||
| 57 | 4442 | int editDistance(const QString &a, const QString &b) { | |
| 58 | 4442 | const int n = int(a.size()); | |
| 59 | 4442 | const int m = int(b.size()); | |
| 60 |
2/2✓ Branch 4 → 5 taken 4442 times.
✓ Branch 5 → 6 taken 4442 times.
|
4442 | QList<QList<int>> d(n + 1, QList<int>(m + 1, 0)); |
| 61 |
4/4✓ Branch 8 → 9 taken 28115 times.
✓ Branch 9 → 10 taken 28115 times.
✓ Branch 11 → 8 taken 28115 times.
✓ Branch 11 → 12 taken 4442 times.
|
32557 | for (int i = 0; i <= n; ++i) d[i][0] = i; |
| 62 |
4/4✓ Branch 13 → 14 taken 36685 times.
✓ Branch 14 → 15 taken 36685 times.
✓ Branch 16 → 13 taken 36685 times.
✓ Branch 16 → 17 taken 4442 times.
|
41127 | for (int j = 0; j <= m; ++j) d[0][j] = j; |
| 63 |
2/2✓ Branch 64 → 18 taken 23673 times.
✓ Branch 64 → 65 taken 4442 times.
|
28115 | for (int i = 1; i <= n; ++i) { |
| 64 |
2/2✓ Branch 62 → 19 taken 172069 times.
✓ Branch 62 → 63 taken 23673 times.
|
195742 | for (int j = 1; j <= m; ++j) { |
| 65 |
2/2✓ Branch 24 → 25 taken 11094 times.
✓ Branch 24 → 26 taken 160975 times.
|
172069 | const int cost = a.at(i - 1).toLower() == b.at(j - 1).toLower() ? 0 : 1; |
| 66 |
9/9✓ Branch 27 → 28 taken 172069 times.
✓ Branch 28 → 29 taken 172069 times.
✓ Branch 29 → 30 taken 172069 times.
✓ Branch 30 → 31 taken 172069 times.
✓ Branch 31 → 32 taken 172069 times.
✓ Branch 32 → 33 taken 172069 times.
✓ Branch 33 → 34 taken 172069 times.
✓ Branch 34 → 35 taken 172069 times.
✓ Branch 35 → 36 taken 172069 times.
|
172069 | d[i][j] = std::min({d[i - 1][j] + 1, d[i][j - 1] + 1, d[i - 1][j - 1] + cost}); |
| 67 |
10/10✓ Branch 36 → 37 taken 139826 times.
✓ Branch 36 → 51 taken 32243 times.
✓ Branch 37 → 38 taken 120595 times.
✓ Branch 37 → 51 taken 19231 times.
✓ Branch 43 → 44 taken 8330 times.
✓ Branch 43 → 51 taken 112265 times.
✓ Branch 49 → 50 taken 467 times.
✓ Branch 49 → 51 taken 7863 times.
✓ Branch 52 → 53 taken 467 times.
✓ Branch 52 → 61 taken 171602 times.
|
172069 | if (i > 1 && j > 1 && a.at(i - 1).toLower() == b.at(j - 2).toLower() && a.at(i - 2).toLower() == b.at(j - 1).toLower()) |
| 68 |
6/6✓ Branch 53 → 54 taken 467 times.
✓ Branch 54 → 55 taken 467 times.
✓ Branch 55 → 56 taken 467 times.
✓ Branch 56 → 57 taken 467 times.
✓ Branch 58 → 59 taken 467 times.
✓ Branch 59 → 60 taken 467 times.
|
467 | d[i][j] = std::min(d[i][j], d[i - 2][j - 2] + 1); |
| 69 | } | ||
| 70 | } | ||
| 71 |
2/2✓ Branch 65 → 66 taken 4442 times.
✓ Branch 66 → 67 taken 4442 times.
|
8884 | return d[n][m]; |
| 72 | 4442 | } | |
| 73 | |||
| 74 | 28 | QString correction(const QString &input, const Sources &sources) { | |
| 75 |
2/2✓ Branch 2 → 3 taken 28 times.
✓ Branch 3 → 4 taken 28 times.
|
28 | const QString text = input.trimmed().left(MaxInput); |
| 76 |
1/2✗ Branch 6 → 7 not taken.
✓ Branch 6 → 8 taken 28 times.
|
28 | if (text.isEmpty()) return {}; |
| 77 |
1/1✓ Branch 11 → 12 taken 28 times.
|
28 | const QString first = text.section(QLatin1Char(' '), 0, 0); |
| 78 |
1/1✓ Branch 15 → 16 taken 28 times.
|
28 | const QString rest = text.section(QLatin1Char(' '), 1); |
| 79 |
4/4✓ Branch 16 → 17 taken 28 times.
✓ Branch 17 → 18 taken 6 times.
✓ Branch 17 → 20 taken 22 times.
✓ Branch 18 → 19 taken 6 times.
|
28 | if (const auto *spec = NamedCommandCatalog::find(first)) return correctValues(*spec, rest); |
| 80 | 22 | QString best; | |
| 81 | 22 | int bestDistance = allowedDistance(first) + 1; | |
| 82 |
3/3✓ Branch 21 → 22 taken 22 times.
✓ Branch 60 → 24 taken 1144 times.
✓ Branch 60 → 61 taken 22 times.
|
1166 | for (const auto &spec : NamedCommandCatalog::specs()) { |
| 83 |
3/3✓ Branch 25 → 26 taken 1144 times.
✓ Branch 28 → 29 taken 178 times.
✓ Branch 28 → 30 taken 966 times.
|
1144 | if (!availabilityReason(spec, spec.name, sources).isEmpty()) continue; |
| 84 |
2/4✓ Branch 33 → 34 taken 966 times.
✓ Branch 33 → 35 taken 966 times.
✗ Branch 96 → 97 not taken.
✗ Branch 96 → 98 not taken.
|
1932 | QStringList words{spec.name}; |
| 85 |
3/3✓ Branch 36 → 37 taken 966 times.
✓ Branch 40 → 41 taken 966 times.
✓ Branch 41 → 42 taken 966 times.
|
966 | words << QString::fromUtf8(spec.keywords).split(QLatin1Char(' '), Qt::SkipEmptyParts); |
| 86 |
4/4✓ Branch 44 → 45 taken 966 times.
✓ Branch 45 → 46 taken 966 times.
✓ Branch 54 → 47 taken 4415 times.
✓ Branch 54 → 55 taken 966 times.
|
5381 | for (const QString &word : words) { |
| 87 |
1/1✓ Branch 48 → 49 taken 4415 times.
|
4415 | const int distance = editDistance(first, word); |
| 88 |
2/2✓ Branch 49 → 50 taken 14 times.
✓ Branch 49 → 52 taken 4401 times.
|
4415 | if (distance < bestDistance) { best = spec.name; bestDistance = distance; } |
| 89 | } | ||
| 90 | 966 | } | |
| 91 |
5/6✓ Branch 62 → 63 taken 14 times.
✓ Branch 62 → 65 taken 8 times.
✗ Branch 64 → 65 not taken.
✓ Branch 64 → 66 taken 14 times.
✓ Branch 67 → 68 taken 8 times.
✓ Branch 67 → 69 taken 14 times.
|
22 | if (best.isEmpty() || best == first) return {}; |
| 92 |
4/4✓ Branch 70 → 71 taken 12 times.
✓ Branch 70 → 72 taken 2 times.
✓ Branch 74 → 75 taken 2 times.
✓ Branch 75 → 76 taken 14 times.
|
14 | return best + (rest.isEmpty() ? QString{} : QLatin1Char(' ') + rest); |
| 93 | 994 | } | |
| 94 | |||
| 95 | } // namespace CommandCompletion | ||
| 96 |