data/ContactStoreLegacy.cpp
| Line | Branch | Exec | Source |
|---|---|---|---|
| 1 | // The legacy part of ContactStore (Sprint 97 D-5, Sprint 103 F103-27): the | ||
| 2 | // placeholder cards of the pre-Sprint-97 contact table — replaced by their | ||
| 3 | // book's first fetch, or retired with the internal "legacy" book —, the | ||
| 4 | // local-only cards waiting for upload, and dropping the old table. | ||
| 5 | |||
| 6 | #include "ContactStore.h" | ||
| 7 | |||
| 8 | #include "ContactSqlValue.h" | ||
| 9 | |||
| 10 | #include <QFile> | ||
| 11 | #include <QLoggingCategory> | ||
| 12 | #include <QSqlError> | ||
| 13 | #include <QSqlQuery> | ||
| 14 | |||
| 15 | Q_DECLARE_LOGGING_CATEGORY(lcContactStore) | ||
| 16 | |||
| 17 | 31 | int ContactStore::removeLegacyCards(qint64 bookId) { | |
| 18 |
1/1✓ Branch 2 → 3 taken 31 times.
|
31 | QSqlQuery q(m_db); |
| 19 |
1/1✓ Branch 6 → 7 taken 31 times.
|
31 | q.prepare(QStringLiteral("DELETE FROM cards WHERE book_id = ? AND sync_state = 'legacy'")); |
| 20 |
2/2✓ Branch 11 → 12 taken 31 times.
✓ Branch 12 → 13 taken 31 times.
|
31 | q.addBindValue(sqlValue(bookId)); |
| 21 |
3/4✓ Branch 15 → 16 taken 31 times.
✓ Branch 16 → 17 taken 31 times.
✗ Branch 16 → 19 not taken.
✓ Branch 17 → 18 taken 31 times.
|
62 | return q.exec() ? q.numRowsAffected() : 0; |
| 22 | 31 | } | |
| 23 | |||
| 24 | 275 | QList<qint64> ContactStore::pendingLocalOnlyCards() const { | |
| 25 | 275 | QList<qint64> ids; | |
| 26 |
6/6✓ Branch 5 → 6 taken 275 times.
✓ Branch 9 → 10 taken 275 times.
✓ Branch 13 → 14 taken 275 times.
✓ Branch 14 → 15 taken 275 times.
✓ Branch 26 → 16 taken 5 times.
✓ Branch 26 → 27 taken 275 times.
|
280 | for (const QString &id : meta(QStringLiteral("legacyLocalPending")).split(QLatin1Char(','), Qt::SkipEmptyParts)) |
| 27 |
3/4✓ Branch 17 → 18 taken 5 times.
✓ Branch 18 → 19 taken 5 times.
✓ Branch 21 → 22 taken 5 times.
✗ Branch 21 → 24 not taken.
|
5 | if (cardById(id.toLongLong())) |
| 28 |
2/2✓ Branch 22 → 23 taken 5 times.
✓ Branch 23 → 24 taken 5 times.
|
280 | ids.append(id.toLongLong()); |
| 29 | 275 | return ids; | |
| 30 | ✗ | } | |
| 31 | |||
| 32 |
1/1✓ Branch 6 → 7 taken 5 times.
|
10 | void ContactStore::clearPendingLocalOnlyCards() { setMeta(QStringLiteral("legacyLocalPending"), QString()); } |
| 33 | |||
| 34 | namespace { | ||
| 35 | |||
| 36 | 2 | bool legacyDuplicate(const QSqlDatabase &db, qint64 legacyBook, qint64 cardId, const QString &name) { | |
| 37 |
1/1✓ Branch 2 → 3 taken 2 times.
|
2 | QSqlQuery addresses(db); |
| 38 |
1/1✓ Branch 6 → 7 taken 2 times.
|
2 | addresses.prepare(QStringLiteral("SELECT COUNT(*), SUM(EXISTS (SELECT 1 FROM card_addresses o JOIN cards c ON" |
| 39 | " c.id = o.card_id WHERE c.book_id <> ? AND o.address_key = a.address_key))" | ||
| 40 | " FROM card_addresses a WHERE a.card_id = ?")); | ||
| 41 |
1/1✓ Branch 11 → 12 taken 2 times.
|
2 | addresses.addBindValue(legacyBook); |
| 42 |
1/1✓ Branch 15 → 16 taken 2 times.
|
2 | addresses.addBindValue(cardId); |
| 43 |
5/8✓ Branch 17 → 18 taken 2 times.
✓ Branch 18 → 19 taken 2 times.
✗ Branch 18 → 21 not taken.
✓ Branch 19 → 20 taken 2 times.
✗ Branch 20 → 21 not taken.
✓ Branch 20 → 22 taken 2 times.
✗ Branch 23 → 24 not taken.
✓ Branch 23 → 25 taken 2 times.
|
2 | if (!addresses.exec() || !addresses.next()) |
| 44 | ✗ | return false; | |
| 45 |
2/2✓ Branch 25 → 26 taken 2 times.
✓ Branch 26 → 27 taken 2 times.
|
2 | const int total = addresses.value(0).toInt(); |
| 46 |
1/2✓ Branch 28 → 29 taken 2 times.
✗ Branch 28 → 34 not taken.
|
2 | if (total > 0) |
| 47 |
2/2✓ Branch 29 → 30 taken 2 times.
✓ Branch 30 → 31 taken 2 times.
|
2 | return addresses.value(1).toInt() == total; // every address is on a real card |
| 48 | ✗ | QSqlQuery named(db); | |
| 49 | ✗ | named.prepare(QStringLiteral("SELECT 1 FROM cards WHERE book_id <> ? AND display_name <> ''" | |
| 50 | " AND lower(display_name) = lower(?) LIMIT 1")); | ||
| 51 | ✗ | named.addBindValue(legacyBook); | |
| 52 | ✗ | named.addBindValue(name); | |
| 53 | ✗ | return !name.isEmpty() && named.exec() && named.next(); | |
| 54 | 2 | } | |
| 55 | |||
| 56 | } // namespace | ||
| 57 | |||
| 58 | 68 | ContactStore::LegacyRetirement ContactStore::retireLegacyBook() { | |
| 59 | 68 | LegacyRetirement result; | |
| 60 |
1/1✓ Branch 2 → 3 taken 68 times.
|
68 | QSqlQuery book(m_db); |
| 61 |
6/13✓ Branch 6 → 7 taken 68 times.
✓ Branch 7 → 8 taken 68 times.
✗ Branch 7 → 10 not taken.
✓ Branch 12 → 13 taken 68 times.
✗ Branch 12 → 14 not taken.
✓ Branch 14 → 15 taken 68 times.
✗ Branch 14 → 16 not taken.
✓ Branch 16 → 17 taken 66 times.
✓ Branch 16 → 18 taken 2 times.
✗ Branch 258 → 259 not taken.
✗ Branch 258 → 260 not taken.
✗ Branch 262 → 263 not taken.
✗ Branch 262 → 264 not taken.
|
204 | if (!book.exec(QStringLiteral("SELECT id FROM address_books WHERE account_id = '' AND path = 'legacy'")) || |
| 62 |
3/3✓ Branch 8 → 9 taken 68 times.
✓ Branch 9 → 10 taken 66 times.
✓ Branch 9 → 11 taken 2 times.
|
68 | !book.next()) |
| 63 | 66 | return result; | |
| 64 |
2/2✓ Branch 18 → 19 taken 2 times.
✓ Branch 19 → 20 taken 2 times.
|
2 | const qint64 legacyBook = book.value(0).toLongLong(); |
| 65 |
1/1✓ Branch 21 → 22 taken 2 times.
|
2 | book.finish(); |
| 66 |
1/1✓ Branch 22 → 23 taken 2 times.
|
2 | QSqlQuery unfetched(m_db); |
| 67 |
3/8✓ Branch 39 → 40 taken 2 times.
✗ Branch 39 → 41 not taken.
✓ Branch 41 → 42 taken 1 time.
✓ Branch 41 → 43 taken 1 time.
✗ Branch 273 → 274 not taken.
✗ Branch 273 → 275 not taken.
✗ Branch 277 → 278 not taken.
✗ Branch 277 → 279 not taken.
|
4 | if (unfetched.exec(QStringLiteral("SELECT COUNT(*) FROM address_books WHERE account_id <> '' AND fetched = 0")) && |
| 68 |
10/16✓ Branch 26 → 27 taken 2 times.
✓ Branch 27 → 28 taken 2 times.
✗ Branch 27 → 34 not taken.
✓ Branch 28 → 29 taken 2 times.
✓ Branch 29 → 30 taken 2 times.
✗ Branch 29 → 34 not taken.
✓ Branch 30 → 31 taken 2 times.
✓ Branch 31 → 32 taken 2 times.
✓ Branch 32 → 33 taken 1 time.
✓ Branch 32 → 34 taken 1 time.
✓ Branch 35 → 36 taken 2 times.
✗ Branch 35 → 37 not taken.
✓ Branch 37 → 38 taken 2 times.
✗ Branch 37 → 39 not taken.
✗ Branch 269 → 270 not taken.
✗ Branch 269 → 271 not taken.
|
4 | unfetched.next() && unfetched.value(0).toInt() > 0) { |
| 69 | 1 | result.waiting = true; | |
| 70 | 1 | return result; | |
| 71 | } | ||
| 72 |
1/1✓ Branch 43 → 44 taken 1 time.
|
1 | unfetched.finish(); |
| 73 | struct Placeholder { | ||
| 74 | qint64 id = 0; | ||
| 75 | QString uid; | ||
| 76 | QString name; | ||
| 77 | }; | ||
| 78 | 1 | QList<Placeholder> placeholders; | |
| 79 |
1/1✓ Branch 44 → 45 taken 1 time.
|
1 | QSqlQuery cards(m_db); |
| 80 |
1/1✓ Branch 48 → 49 taken 1 time.
|
1 | cards.prepare(QStringLiteral("SELECT id, uid, display_name FROM cards WHERE book_id = ?")); |
| 81 |
1/1✓ Branch 53 → 54 taken 1 time.
|
1 | cards.addBindValue(legacyBook); |
| 82 |
2/3✓ Branch 55 → 56 taken 1 time.
✓ Branch 56 → 57 taken 1 time.
✗ Branch 56 → 72 not taken.
|
1 | if (cards.exec()) |
| 83 |
3/3✓ Branch 70 → 71 taken 3 times.
✓ Branch 71 → 58 taken 2 times.
✓ Branch 71 → 72 taken 1 time.
|
3 | while (cards.next()) |
| 84 |
2/2✓ Branch 58 → 59 taken 2 times.
✓ Branch 59 → 60 taken 2 times.
|
4 | placeholders.append({cards.value(0).toLongLong(), cards.value(1).toString(), cards.value(2).toString()}); |
| 85 |
1/1✓ Branch 72 → 73 taken 1 time.
|
1 | cards.finish(); |
| 86 |
1/1✓ Branch 73 → 74 taken 1 time.
|
1 | const qint64 local = localBookId(); |
| 87 |
2/2✓ Branch 77 → 78 taken 1 time.
✓ Branch 81 → 82 taken 1 time.
|
1 | QStringList pending = meta(QStringLiteral("legacyLocalPending")).split(QLatin1Char(','), Qt::SkipEmptyParts); |
| 88 | // S106-168: one transaction whose every step counts — a failure rolls the | ||
| 89 | // whole retirement back (it is retried on the next start). | ||
| 90 |
2/3✓ Branch 85 → 86 taken 1 time.
✗ Branch 86 → 87 not taken.
✓ Branch 86 → 103 taken 1 time.
|
1 | if (!m_db.transaction()) { |
| 91 | ✗ | qCWarning(lcContactStore) << "Legacy book retirement: transaction:" << m_db.lastError().text(); | |
| 92 | ✗ | return {}; | |
| 93 | } | ||
| 94 | ✗ | const auto fail = [&](const QSqlQuery &query) { | |
| 95 | ✗ | qCWarning(lcContactStore) << "Legacy book retirement failed:" << query.lastError().text(); | |
| 96 | ✗ | m_db.rollback(); | |
| 97 | ✗ | return LegacyRetirement{}; | |
| 98 | 1 | }; | |
| 99 |
2/2✓ Branch 184 → 106 taken 2 times.
✓ Branch 184 → 185 taken 1 time.
|
3 | for (const Placeholder &card : std::as_const(placeholders)) { |
| 100 |
1/1✓ Branch 107 → 108 taken 2 times.
|
2 | QSqlQuery change(m_db); |
| 101 |
1/1✓ Branch 108 → 109 taken 2 times.
|
2 | QSqlQuery taken(m_db); |
| 102 |
1/1✓ Branch 112 → 113 taken 2 times.
|
2 | taken.prepare(QStringLiteral("SELECT 1 FROM cards WHERE book_id = ? AND uid = ?")); |
| 103 |
1/1✓ Branch 117 → 118 taken 2 times.
|
2 | taken.addBindValue(local); |
| 104 |
1/1✓ Branch 121 → 122 taken 2 times.
|
2 | taken.addBindValue(card.uid); |
| 105 |
2/3✓ Branch 123 → 124 taken 2 times.
✗ Branch 124 → 125 not taken.
✓ Branch 124 → 127 taken 2 times.
|
2 | if (!taken.exec()) |
| 106 | ✗ | return fail(taken); | |
| 107 |
1/1✓ Branch 127 → 128 taken 2 times.
|
2 | const bool uidTaken = taken.next(); |
| 108 |
6/7✓ Branch 128 → 129 taken 2 times.
✓ Branch 129 → 130 taken 1 time.
✓ Branch 129 → 131 taken 1 time.
✗ Branch 130 → 131 not taken.
✓ Branch 130 → 132 taken 1 time.
✓ Branch 133 → 134 taken 1 time.
✓ Branch 133 → 149 taken 1 time.
|
2 | if (legacyDuplicate(m_db, legacyBook, card.id, card.name) || uidTaken) { |
| 109 |
1/1✓ Branch 137 → 138 taken 1 time.
|
1 | change.prepare(QStringLiteral("DELETE FROM cards WHERE id = ?")); |
| 110 |
1/1✓ Branch 142 → 143 taken 1 time.
|
1 | change.addBindValue(card.id); |
| 111 |
2/3✓ Branch 144 → 145 taken 1 time.
✗ Branch 145 → 146 not taken.
✓ Branch 145 → 148 taken 1 time.
|
1 | if (!change.exec()) |
| 112 | ✗ | return fail(change); | |
| 113 | 1 | ++result.removed; | |
| 114 | 1 | continue; | |
| 115 | } | ||
| 116 |
1/1✓ Branch 152 → 153 taken 1 time.
|
1 | change.prepare(QStringLiteral("UPDATE cards SET book_id = ?, sync_state = '', writable = 1, href = '', etag = ''" |
| 117 | " WHERE id = ?")); | ||
| 118 |
1/1✓ Branch 157 → 158 taken 1 time.
|
1 | change.addBindValue(local); |
| 119 |
1/1✓ Branch 161 → 162 taken 1 time.
|
1 | change.addBindValue(card.id); |
| 120 |
2/3✓ Branch 163 → 164 taken 1 time.
✗ Branch 164 → 165 not taken.
✓ Branch 164 → 167 taken 1 time.
|
1 | if (!change.exec()) |
| 121 | ✗ | return fail(change); | |
| 122 | 1 | ++result.moved; | |
| 123 |
2/2✓ Branch 167 → 168 taken 1 time.
✓ Branch 168 → 169 taken 1 time.
|
1 | pending << QString::number(card.id); |
| 124 | 3 | } | |
| 125 |
1/1✓ Branch 185 → 186 taken 1 time.
|
1 | QSqlQuery remove(m_db); |
| 126 |
1/1✓ Branch 189 → 190 taken 1 time.
|
1 | remove.prepare(QStringLiteral("DELETE FROM address_books WHERE id = ? AND NOT EXISTS" |
| 127 | " (SELECT 1 FROM cards WHERE book_id = ?)")); | ||
| 128 |
1/1✓ Branch 194 → 195 taken 1 time.
|
1 | remove.addBindValue(legacyBook); |
| 129 |
1/1✓ Branch 198 → 199 taken 1 time.
|
1 | remove.addBindValue(legacyBook); |
| 130 |
2/3✓ Branch 200 → 201 taken 1 time.
✗ Branch 201 → 202 not taken.
✓ Branch 201 → 204 taken 1 time.
|
1 | if (!remove.exec()) |
| 131 | ✗ | return fail(remove); | |
| 132 |
2/3✓ Branch 204 → 205 taken 1 time.
✗ Branch 205 → 206 not taken.
✓ Branch 205 → 223 taken 1 time.
|
1 | if (!m_db.commit()) { |
| 133 | ✗ | qCWarning(lcContactStore) << "Legacy book retirement: commit:" << m_db.lastError().text(); | |
| 134 | ✗ | m_db.rollback(); | |
| 135 | ✗ | return {}; | |
| 136 | } | ||
| 137 |
1/2✓ Branch 223 → 224 taken 1 time.
✗ Branch 223 → 235 not taken.
|
1 | if (result.moved > 0) |
| 138 |
2/2✓ Branch 226 → 227 taken 1 time.
✓ Branch 230 → 231 taken 1 time.
|
2 | setMeta(QStringLiteral("legacyLocalPending"), pending.join(QLatin1Char(','))); |
| 139 |
7/7✓ Branch 235 → 236 taken 1 time.
✓ Branch 239 → 240 taken 1 time.
✓ Branch 240 → 241 taken 1 time.
✓ Branch 241 → 242 taken 1 time.
✓ Branch 242 → 243 taken 1 time.
✓ Branch 248 → 237 taken 1 time.
✓ Branch 248 → 249 taken 1 time.
|
2 | qCInfo(lcContactStore) << "Legacy book retired:" << result.removed << "placeholders removed as duplicates," |
| 140 |
2/2✓ Branch 243 → 244 taken 1 time.
✓ Branch 244 → 245 taken 1 time.
|
1 | << result.moved << "kept as local contacts"; |
| 141 | 1 | return result; | |
| 142 | 70 | } | |
| 143 | |||
| 144 | 68 | void ContactStore::dropLegacyTableWhenDone() { | |
| 145 |
3/3✓ Branch 6 → 7 taken 68 times.
✓ Branch 11 → 12 taken 63 times.
✓ Branch 11 → 13 taken 5 times.
|
136 | if (meta(QStringLiteral("legacyTable")) != QLatin1String("present")) |
| 146 | 64 | return; | |
| 147 |
1/1✓ Branch 13 → 14 taken 5 times.
|
5 | QSqlQuery remaining(m_db); |
| 148 |
1/1✓ Branch 17 → 18 taken 5 times.
|
5 | remaining.exec(QStringLiteral("SELECT COUNT(*) FROM cards WHERE sync_state = 'legacy'")); |
| 149 |
7/11✓ Branch 20 → 21 taken 5 times.
✓ Branch 21 → 22 taken 5 times.
✗ Branch 21 → 26 not taken.
✓ Branch 22 → 23 taken 5 times.
✓ Branch 23 → 24 taken 5 times.
✓ Branch 24 → 25 taken 4 times.
✓ Branch 24 → 26 taken 1 time.
✓ Branch 27 → 28 taken 5 times.
✗ Branch 27 → 29 not taken.
✗ Branch 98 → 99 not taken.
✗ Branch 98 → 100 not taken.
|
5 | const bool done = remaining.next() && remaining.value(0).toInt() == 0; |
| 150 |
1/1✓ Branch 29 → 30 taken 5 times.
|
5 | remaining.finish(); // an active statement would lock the table for DROP |
| 151 |
2/2✓ Branch 30 → 31 taken 1 time.
✓ Branch 30 → 32 taken 4 times.
|
5 | if (!done) |
| 152 | 1 | return; | |
| 153 | // Cards of books that left the selection before their first fetch. | ||
| 154 |
1/1✓ Branch 32 → 33 taken 4 times.
|
4 | QSqlQuery cleanup(m_db); |
| 155 |
1/1✓ Branch 36 → 37 taken 4 times.
|
4 | cleanup.exec(QStringLiteral("DELETE FROM address_books WHERE account_id = '' AND path = 'legacy'")); |
| 156 |
2/3✓ Branch 42 → 43 taken 4 times.
✓ Branch 45 → 46 taken 4 times.
✗ Branch 45 → 76 not taken.
|
4 | if (cleanup.exec(QStringLiteral("DROP TABLE IF EXISTS contacts"))) { |
| 157 |
1/1✓ Branch 52 → 53 taken 4 times.
|
8 | setMeta(QStringLiteral("legacyTable"), QStringLiteral("dropped")); |
| 158 |
2/2✓ Branch 60 → 61 taken 4 times.
✓ Branch 61 → 62 taken 4 times.
|
4 | QFile::remove(m_dbPath + QStringLiteral(".pre-v1")); |
| 159 |
5/5✓ Branch 65 → 66 taken 4 times.
✓ Branch 69 → 70 taken 4 times.
✓ Branch 70 → 71 taken 4 times.
✓ Branch 74 → 67 taken 4 times.
✓ Branch 74 → 75 taken 4 times.
|
8 | qCInfo(lcContactStore) << "Every address book was fetched; the pre-Sprint-97 contact table was dropped"; |
| 160 | } | ||
| 161 | 5 | } | |
| 162 |