MailJDTourDownloadDocsQualityTestsCoverage

Which source lines and branches the tests execute. Lines 91.5 %, branches 75.0 % (minimum 85 % and 72 %). main @ 399ffe3d · 21 October 2026 · pipeline 7238.

GCC Code Coverage Report


Directory: src/
Coverage: low: ≥ 0% medium: ≥ 75.0% high: ≥ 90.0%
Coverage Exec / Excl / Total
Lines: 98.4% 61 / 0 / 62
Functions: 100.0% 9 / 0 / 9
Branches: 82.4% 89 / 0 / 108

presentation/QuickContactActionsLinks.cpp
Line Branch Exec Source
1 // Mail links of QuickContactActions (Sprint 103 S103.6.3/S103.1.11, D-15):
2 // "this mail is about the person" as X-MAILJD-MAIL lines on the card
3 // (Message-ID, subject, day), written through the outbox like any edit.
4 // A card keeps at most VCardCodec::MaxMailLinks; the oldest link gives way.
5 // The reverse lookup uses the derived card_mail_links index.
6
7 #include "QuickContactActions.h"
8
9 #include "app/core/ContactSyncCoordinator.h"
10 #include "data/ContactQueries.h"
11 #include "data/ContactStore.h"
12 #include "MentionRule.h"
13 #include "data/VCardCodec.h"
14
15 #include <QLoggingCategory>
16 #include <QSqlQuery>
17 #include <algorithm>
18
19 Q_DECLARE_LOGGING_CATEGORY(lcContactRelationActions)
20
21 namespace {
22
23 362 QString bare(QString messageId) {
24
1/1
✓ Branch 2 → 3 taken 362 times.
362 messageId = messageId.trimmed();
25
7/8
✓ Branch 7 → 8 taken 362 times.
✓ Branch 8 → 9 taken 3 times.
✓ Branch 8 → 14 taken 359 times.
✓ Branch 11 → 12 taken 3 times.
✓ Branch 12 → 13 taken 3 times.
✗ Branch 12 → 14 not taken.
✓ Branch 15 → 16 taken 3 times.
✓ Branch 15 → 21 taken 359 times.
362 if (messageId.startsWith(QLatin1Char('<')) && messageId.endsWith(QLatin1Char('>')))
26
1/1
✓ Branch 17 → 18 taken 3 times.
3 messageId = messageId.mid(1, messageId.size() - 2);
27 362 return messageId;
28 }
29
30 } // namespace
31
32 57 QVariantMap QuickContactActions::linkMail(const QString &key, const QString &messageId, const QString &subject,
33 const QString &dateIso) {
34
1/1
✓ Branch 3 → 4 taken 57 times.
57 const QString id = bare(messageId);
35
5/6
✓ Branch 6 → 7 taken 56 times.
✓ Branch 6 → 9 taken 1 time.
✗ Branch 8 → 9 not taken.
✓ Branch 8 → 10 taken 56 times.
✓ Branch 11 → 12 taken 1 time.
✓ Branch 11 → 31 taken 56 times.
57 if (id.isEmpty() || id.size() > VCardCodec::MaxMessageIdLength)
36
3/5
✓ Branch 19 → 20 taken 1 time.
✓ Branch 23 → 24 taken 2 times.
✓ Branch 23 → 25 taken 1 time.
✗ Branch 82 → 83 not taken.
✗ Branch 82 → 84 not taken.
6 return {{QStringLiteral("ok"), false}, {QStringLiteral("error"), tr("This mail has no Message-ID to link.")}};
37 56 const QVariantMap result = editPeople(
38 key,
39
1/1
✓ Branch 32 → 33 taken 56 times.
56 [&](ContactCard *card) -> QString {
40
4/4
✓ Branch 2 → 3 taken 56 times.
✓ Branch 3 → 4 taken 56 times.
✓ Branch 12 → 5 taken 1277 times.
✓ Branch 12 → 13 taken 55 times.
1332 for (const ContactMailLink &link : card->mailLinks)
41
2/2
✓ Branch 7 → 8 taken 1 time.
✓ Branch 7 → 10 taken 1276 times.
1277 if (link.messageId == id)
42
1/1
✓ Branch 8 → 9 taken 1 time.
1 return tr("This mail is already linked to the contact.");
43 // The oldest link gives way at the cap.
44
2/2
✓ Branch 21 → 14 taken 1 time.
✓ Branch 21 → 22 taken 55 times.
56 while (card->mailLinks.size() >= VCardCodec::MaxMailLinks) {
45
3/3
✓ Branch 14 → 15 taken 1 time.
✓ Branch 15 → 16 taken 1 time.
✓ Branch 16 → 17 taken 1 time.
1 const auto oldest = std::min_element(card->mailLinks.begin(), card->mailLinks.end(),
46 49 [](const ContactMailLink &a, const ContactMailLink &b) {
47 49 return a.date < b.date;
48 });
49
1/1
✓ Branch 18 → 19 taken 1 time.
1 card->mailLinks.erase(oldest);
50 }
51 55 card->mailLinks.append({id, subject.left(200), dateIso.left(10), -1});
52 55 return {};
53
3/9
✓ Branch 23 → 24 taken 55 times.
✓ Branch 24 → 25 taken 55 times.
✓ Branch 25 → 26 taken 55 times.
✗ Branch 34 → 35 not taken.
✗ Branch 34 → 36 not taken.
✗ Branch 37 → 38 not taken.
✗ Branch 37 → 39 not taken.
✗ Branch 40 → 41 not taken.
✗ Branch 40 → 42 not taken.
55 },
54
2/2
✓ Branch 31 → 32 taken 56 times.
✓ Branch 33 → 34 taken 56 times.
168 tr("Mail linked"));
55
11/11
✓ Branch 36 → 37 taken 56 times.
✓ Branch 40 → 41 taken 56 times.
✓ Branch 41 → 42 taken 56 times.
✓ Branch 42 → 43 taken 56 times.
✓ Branch 47 → 48 taken 56 times.
✓ Branch 48 → 49 taken 56 times.
✓ Branch 49 → 50 taken 55 times.
✓ Branch 49 → 51 taken 1 time.
✓ Branch 52 → 53 taken 56 times.
✓ Branch 60 → 38 taken 56 times.
✓ Branch 60 → 61 taken 56 times.
112 qCInfo(lcContactRelationActions) << "Link mail to" << key << (result.value(QStringLiteral("ok")).toBool() ? "done" : "refused");
56
4/4
✓ Branch 65 → 66 taken 56 times.
✓ Branch 66 → 67 taken 56 times.
✓ Branch 71 → 72 taken 55 times.
✓ Branch 71 → 73 taken 1 time.
112 if (result.value(QStringLiteral("ok")).toBool())
57
1/1
✓ Branch 72 → 73 taken 55 times.
55 emit mailLinksChanged();
58 56 return result;
59 61 }
60
61 1 QVariantMap QuickContactActions::unlinkMail(const QString &key, const QString &messageId) {
62
1/1
✓ Branch 3 → 4 taken 1 time.
1 const QString id = bare(messageId);
63 1 const QVariantMap result = editPeople(
64 key,
65 1 [&id](ContactCard *card) -> QString {
66 1 const auto before = card->mailLinks.size();
67 2 card->mailLinks.removeIf([&id](const ContactMailLink &link) { return link.messageId == id; });
68
1/2
✗ Branch 5 → 6 not taken.
✓ Branch 5 → 7 taken 1 time.
1 return card->mailLinks.size() == before ? tr("This mail is not linked to the contact.") : QString();
69 },
70
2/2
✓ Branch 5 → 6 taken 1 time.
✓ Branch 7 → 8 taken 1 time.
3 tr("Link removed"));
71
3/4
✓ Branch 14 → 15 taken 1 time.
✓ Branch 15 → 16 taken 1 time.
✓ Branch 20 → 21 taken 1 time.
✗ Branch 20 → 22 not taken.
2 if (result.value(QStringLiteral("ok")).toBool())
72
1/1
✓ Branch 21 → 22 taken 1 time.
1 emit mailLinksChanged();
73 1 return result;
74 1 }
75
76 304 QVariantList QuickContactActions::cardsAboutMail(const QString &messageId) const {
77
1/1
✓ Branch 2 → 3 taken 304 times.
304 ContactSyncCoordinator *sync = m_coordinator();
78
1/1
✓ Branch 4 → 5 taken 304 times.
304 const QString id = bare(messageId);
79
3/6
✓ Branch 6 → 7 taken 304 times.
✗ Branch 6 → 9 not taken.
✗ Branch 8 → 9 not taken.
✓ Branch 8 → 10 taken 304 times.
✗ Branch 11 → 12 not taken.
✓ Branch 11 → 13 taken 304 times.
304 if (!sync || id.isEmpty())
80 ✗ return {};
81
2/2
✓ Branch 14 → 15 taken 304 times.
✓ Branch 15 → 16 taken 304 times.
304 QSqlQuery q(sync->store()->database());
82
1/1
✓ Branch 20 → 21 taken 304 times.
304 q.prepare(QStringLiteral("SELECT DISTINCT c.book_id, c.uid FROM card_mail_links l JOIN cards c ON c.id = l.card_id"
83 " WHERE l.message_id = ? ORDER BY c.display_name LIMIT 20"));
84
1/1
✓ Branch 25 → 26 taken 304 times.
304 q.addBindValue(id);
85 304 QVariantList out;
86
2/3
✓ Branch 27 → 28 taken 304 times.
✓ Branch 28 → 29 taken 304 times.
✗ Branch 28 → 50 not taken.
304 if (q.exec())
87
3/3
✓ Branch 48 → 49 taken 307 times.
✓ Branch 49 → 30 taken 3 times.
✓ Branch 49 → 50 taken 304 times.
307 while (q.next())
88
6/6
✓ Branch 30 → 31 taken 3 times.
✓ Branch 31 → 32 taken 3 times.
✓ Branch 32 → 33 taken 3 times.
✓ Branch 33 → 34 taken 3 times.
✓ Branch 34 → 35 taken 3 times.
✓ Branch 35 → 36 taken 3 times.
3 if (const QVariantMap entry = personEntry(ContactQueries::cardKey(q.value(0).toLongLong(), q.value(1).toString()));
89
2/3
✓ Branch 40 → 41 taken 3 times.
✓ Branch 41 → 42 taken 3 times.
✗ Branch 41 → 46 not taken.
3 !entry.isEmpty())
90
1/1
✓ Branch 43 → 44 taken 3 times.
3 out.append(entry);
91 304 return out;
92 304 }
93
94 82 QVariantMap QuickContactActions::mentionAt(const QString &text, int cursor) const {
95
1/1
✓ Branch 2 → 3 taken 82 times.
82 const MentionRule::Mention mention = MentionRule::at(text, cursor);
96
2/2
✓ Branch 4 → 5 taken 72 times.
✓ Branch 4 → 6 taken 10 times.
82 if (!mention.valid())
97 72 return {};
98
2/4
✓ Branch 16 → 17 taken 20 times.
✓ Branch 16 → 18 taken 10 times.
✗ Branch 27 → 28 not taken.
✗ Branch 27 → 29 not taken.
50 return {{QStringLiteral("start"), mention.start}, {QStringLiteral("fragment"), mention.fragment}};
99 112 }
100