MailJDTourDownloadDocsQualityTestsCoverage

Which source lines and branches the tests execute. Lines 91.5 %, branches 75.0 % (minimum 85 % and 72 %). main @ 399ffe3d · 21 October 2026 · pipeline 7238.

GCC Code Coverage Report

Directory: src/
Coverage: low: ≥ 0% medium: ≥ 75.0% high: ≥ 90.0%
Coverage Exec / Excl / Total
Lines: 89.3% 117 / 0 / 131
Functions: 100.0% 16 / 0 / 16
Branches: 75.5% 154 / 0 / 204
data/TemplateStore.cpp
Line Branch Exec Source
1 #include "TemplateStore.h"
2
3 #include <QDir>
4 #include <QFile>
5 #include <QFileInfo>
6 #include <QJsonArray>
7 #include <QJsonDocument>
8 #include <QSaveFile>
9 #include <QUuid>
10 #include <algorithm>
11
12 namespace {
13
14 65 QString bounded(const QJsonObject &object, const char *key, qsizetype limit) {
15
2/2
✓ Branch 3 → 4 taken 65 times.
✓ Branch 4 → 5 taken 65 times.
 65 const QString value = object.value(QLatin1String(key)).toString();
16
1/2
✗ Branch 7 → 8 not taken.
✓ Branch 7 → 9 taken 65 times.
 130 return value.size() > limit ? QString() : value;
17 65 }
18
19 251 bool hasLineBreak(const QString &value) {
20
8/9
✓ Branch 4 → 5 taken 251 times.
✓ Branch 5 → 6 taken 249 times.
✓ Branch 5 → 13 taken 2 times.
✓ Branch 8 → 9 taken 249 times.
✓ Branch 9 → 10 taken 247 times.
✓ Branch 9 → 13 taken 2 times.
✓ Branch 11 → 12 taken 247 times.
✗ Branch 12 → 13 not taken.
✓ Branch 12 → 14 taken 247 times.
 251 return value.contains(QLatin1Char('\r')) || value.contains(QLatin1Char('\n')) || value.contains(QChar::Null);
21 }
22
23 } // namespace
24
25 806 QString TemplateStore::pathFor(const QString &profileDirectory) {
26
2/2
✓ Branch 2 → 3 taken 806 times.
✓ Branch 6 → 7 taken 806 times.
 1612 return QDir(profileDirectory).filePath(QStringLiteral("templates.json"));
27 }
28
29 130 bool TemplateStore::validName(const QString &name) {
30
8/12
✓ Branch 2 → 3 taken 130 times.
✓ Branch 4 → 5 taken 128 times.
✓ Branch 4 → 10 taken 2 times.
✓ Branch 6 → 7 taken 128 times.
✗ Branch 6 → 10 not taken.
✓ Branch 7 → 8 taken 128 times.
✓ Branch 8 → 9 taken 126 times.
✓ Branch 8 → 10 taken 2 times.
✓ Branch 12 → 13 taken 130 times.
✗ Branch 12 → 14 not taken.
✗ Branch 16 → 17 not taken.
✗ Branch 16 → 18 not taken.
 130 return !name.trimmed().isEmpty() && name.size() <= MaxNameChars && !hasLineBreak(name);
31 }
32
33 9 QJsonObject TemplateStore::toJson(const MailTemplate &value) {
34 18 return {{QStringLiteral("id"), value.id},
35 18 {QStringLiteral("name"), value.name},
36 18 {QStringLiteral("subject"), value.subject},
37 18 {QStringLiteral("html"), value.html},
38
2/4
✓ Branch 24 → 25 taken 45 times.
✓ Branch 24 → 26 taken 9 times.
✗ Branch 39 → 40 not taken.
✗ Branch 39 → 41 not taken.
 72 {QStringLiteral("text"), value.text}};
39 54 }
40
41 13 std::optional<MailTemplate> TemplateStore::fromJson(const QJsonObject &object) {
42 13 MailTemplate value;
43
1/1
✓ Branch 2 → 3 taken 13 times.
 13 value.id = bounded(object, "id", 64);
44
1/1
✓ Branch 5 → 6 taken 13 times.
 13 value.name = bounded(object, "name", MaxNameChars);
45
1/1
✓ Branch 8 → 9 taken 13 times.
 13 value.subject = bounded(object, "subject", 998);
46
1/1
✓ Branch 11 → 12 taken 13 times.
 13 value.html = bounded(object, "html", MaxTemplateBytes);
47
1/1
✓ Branch 14 → 15 taken 13 times.
 13 value.text = bounded(object, "text", MaxTemplateBytes);
48
10/10
✓ Branch 18 → 19 taken 12 times.
✓ Branch 18 → 23 taken 1 time.
✓ Branch 19 → 20 taken 12 times.
✓ Branch 20 → 21 taken 11 times.
✓ Branch 20 → 23 taken 1 time.
✓ Branch 21 → 22 taken 11 times.
✓ Branch 22 → 23 taken 1 time.
✓ Branch 22 → 24 taken 10 times.
✓ Branch 25 → 26 taken 3 times.
✓ Branch 25 → 27 taken 10 times.
 13 if (value.id.isEmpty() || !validName(value.name) || hasLineBreak(value.subject)) return std::nullopt;
49 10 return value;
50 13 }
51
52 806 bool TemplateStore::load(QString *error) {
53
1/1
✓ Branch 2 → 3 taken 806 times.
 806 m_templates.clear();
54
1/1
✓ Branch 3 → 4 taken 806 times.
 806 QFile file(m_path);
55
3/3
✓ Branch 4 → 5 taken 806 times.
✓ Branch 5 → 6 taken 797 times.
✓ Branch 5 → 7 taken 9 times.
 806 if (!file.exists()) return true;
56
2/3
✓ Branch 7 → 8 taken 9 times.
✗ Branch 8 → 9 not taken.
✓ Branch 8 → 18 taken 9 times.
 9 if (file.size() > MaxFileBytes) {
57 ✗ if (error) *error = QStringLiteral("templates file too large");
58 ✗ return false;
59 }
60
2/3
✓ Branch 19 → 20 taken 9 times.
✗ Branch 20 → 21 not taken.
✓ Branch 20 → 27 taken 9 times.
 9 if (!file.open(QIODevice::ReadOnly)) {
61 ✗ if (error) *error = file.errorString();
62 ✗ return false;
63 }
64 9 QJsonParseError parseError;
65
2/2
✓ Branch 27 → 28 taken 9 times.
✓ Branch 28 → 29 taken 9 times.
 9 const QJsonDocument document = QJsonDocument::fromJson(file.read(MaxFileBytes), &parseError);
66
6/7
✓ Branch 30 → 31 taken 8 times.
✓ Branch 30 → 33 taken 1 time.
✓ Branch 31 → 32 taken 8 times.
✗ Branch 32 → 33 not taken.
✓ Branch 32 → 34 taken 8 times.
✓ Branch 35 → 36 taken 1 time.
✓ Branch 35 → 45 taken 8 times.
 9 if (parseError.error != QJsonParseError::NoError || !document.isObject()) {
67
1/2
✓ Branch 36 → 37 taken 1 time.
✗ Branch 36 → 44 not taken.
 2 if (error) *error = QStringLiteral("templates file is not valid JSON");
68 1 return false;
69 }
70
3/3
✓ Branch 45 → 46 taken 8 times.
✓ Branch 49 → 50 taken 8 times.
✓ Branch 50 → 51 taken 8 times.
 16 const QJsonArray entries = document.object().value(QStringLiteral("templates")).toArray();
71
2/3
✓ Branch 55 → 56 taken 8 times.
✗ Branch 56 → 57 not taken.
✓ Branch 56 → 66 taken 8 times.
 8 if (entries.size() > MaxTemplates) {
72 ✗ if (error) *error = QStringLiteral("too many templates");
73 ✗ return false;
74 }
75 8 QList<MailTemplate> loaded;
76
3/3
✓ Branch 67 → 68 taken 8 times.
✓ Branch 98 → 69 taken 13 times.
✓ Branch 98 → 99 taken 5 times.
 18 for (const QJsonValue &entry : entries) {
77
2/2
✓ Branch 71 → 72 taken 13 times.
✓ Branch 72 → 73 taken 13 times.
 13 const auto value = fromJson(entry.toObject());
78
2/2
✓ Branch 75 → 76 taken 3 times.
✓ Branch 75 → 85 taken 10 times.
 13 if (!value) {
79
1/2
✓ Branch 76 → 77 taken 3 times.
✗ Branch 76 → 84 not taken.
 6 if (error) *error = QStringLiteral("invalid template entry");
80 3 return false;
81 }
82
1/1
✓ Branch 86 → 87 taken 10 times.
 10 loaded.append(*value);
83 16 }
84 5 m_templates = loaded;
85
1/1
✓ Branch 100 → 101 taken 5 times.
 5 sort();
86 5 return true;
87 806 }
88
89 7 bool TemplateStore::save(QString *error) const {
90
1/1
✓ Branch 2 → 3 taken 7 times.
 7 QJsonArray entries;
91
4/4
✓ Branch 6 → 7 taken 9 times.
✓ Branch 8 → 9 taken 9 times.
✓ Branch 13 → 5 taken 9 times.
✓ Branch 13 → 14 taken 7 times.
 16 for (const MailTemplate &value : m_templates) entries.append(toJson(value));
92 const QByteArray bytes =
93
3/5
✓ Branch 23 → 24 taken 7 times.
✓ Branch 28 → 29 taken 14 times.
✓ Branch 28 → 30 taken 7 times.
✗ Branch 93 → 94 not taken.
✗ Branch 93 → 95 not taken.
 42 QJsonDocument(QJsonObject{{QStringLiteral("version"), 1}, {QStringLiteral("templates"), entries}})
94
1/1
✓ Branch 24 → 25 taken 7 times.
 7 .toJson(QJsonDocument::Indented);
95
1/2
✗ Branch 35 → 36 not taken.
✓ Branch 35 → 45 taken 7 times.
 7 if (bytes.size() > MaxFileBytes) {
96 ✗ if (error) *error = QStringLiteral("templates too large to save");
97 ✗ return false;
98 }
99
4/4
✓ Branch 46 → 47 taken 7 times.
✓ Branch 47 → 48 taken 7 times.
✓ Branch 48 → 49 taken 7 times.
✓ Branch 49 → 50 taken 7 times.
 7 QDir().mkpath(QFileInfo(m_path).absolutePath());
100
1/1
✓ Branch 54 → 55 taken 7 times.
 7 QSaveFile file(m_path);
101
4/6
✓ Branch 56 → 57 taken 7 times.
✓ Branch 59 → 60 taken 7 times.
✓ Branch 60 → 61 taken 7 times.
✗ Branch 60 → 66 not taken.
✓ Branch 63 → 64 taken 7 times.
✗ Branch 63 → 66 not taken.
 21 if (!file.open(QIODevice::WriteOnly) || !file.setPermissions(QFile::ReadOwner | QFile::WriteOwner) ||
102
5/8
✓ Branch 57 → 58 taken 7 times.
✗ Branch 57 → 66 not taken.
✓ Branch 61 → 62 taken 7 times.
✓ Branch 64 → 65 taken 7 times.
✗ Branch 65 → 66 not taken.
✓ Branch 65 → 67 taken 7 times.
✗ Branch 68 → 69 not taken.
✓ Branch 68 → 75 taken 7 times.
 21 file.write(bytes) != bytes.size() || !file.commit()) {
103 ✗ if (error) *error = file.errorString();
104 ✗ return false;
105 }
106 7 return true;
107 28 }
108
109 5 std::optional<MailTemplate> TemplateStore::find(const QString &id) const {
110
2/2
✓ Branch 10 → 4 taken 5 times.
✓ Branch 10 → 11 taken 3 times.
 8 for (const MailTemplate &value : m_templates)
111
2/2
✓ Branch 6 → 7 taken 2 times.
✓ Branch 6 → 8 taken 3 times.
 5 if (value.id == id) return value;
112 3 return std::nullopt;
113 }
114
115 122 std::optional<MailTemplate> TemplateStore::findByName(const QString &name) const {
116
1/1
✓ Branch 2 → 3 taken 122 times.
 122 const QString wanted = name.trimmed();
117
2/2
✓ Branch 11 → 5 taken 5075 times.
✓ Branch 11 → 12 taken 113 times.
 5188 for (const MailTemplate &value : m_templates)
118
2/2
✓ Branch 7 → 8 taken 9 times.
✓ Branch 7 → 9 taken 5066 times.
 5075 if (value.name.compare(wanted, Qt::CaseInsensitive) == 0) return value;
119 113 return std::nullopt;
120 122 }
121
122 115 std::optional<MailTemplate> TemplateStore::upsert(MailTemplate value, QString *error) {
123
1/1
✓ Branch 2 → 3 taken 115 times.
 115 value.name = value.name.trimmed();
124
6/6
✓ Branch 6 → 7 taken 112 times.
✓ Branch 6 → 9 taken 3 times.
✓ Branch 8 → 9 taken 1 time.
✓ Branch 8 → 10 taken 111 times.
✓ Branch 11 → 12 taken 4 times.
✓ Branch 11 → 21 taken 111 times.
 115 if (!validName(value.name) || hasLineBreak(value.subject)) {
125
1/2
✓ Branch 12 → 13 taken 4 times.
✗ Branch 12 → 20 not taken.
 8 if (error) *error = QStringLiteral("name");
126 4 return std::nullopt;
127 }
128
5/6
✓ Branch 22 → 23 taken 111 times.
✗ Branch 22 → 25 not taken.
✓ Branch 24 → 25 taken 1 time.
✓ Branch 24 → 26 taken 110 times.
✓ Branch 27 → 28 taken 1 time.
✓ Branch 27 → 37 taken 110 times.
 111 if (value.html.size() > MaxTemplateBytes || value.text.size() > MaxTemplateBytes) {
129
1/2
✓ Branch 28 → 29 taken 1 time.
✗ Branch 28 → 36 not taken.
 2 if (error) *error = QStringLiteral("size");
130 1 return std::nullopt;
131 }
132 // The same name replaces that template (and keeps its id).
133
6/7
✓ Branch 37 → 38 taken 110 times.
✓ Branch 39 → 40 taken 2 times.
✓ Branch 39 → 44 taken 108 times.
✓ Branch 42 → 43 taken 2 times.
✗ Branch 42 → 44 not taken.
✓ Branch 45 → 46 taken 2 times.
✓ Branch 45 → 51 taken 108 times.
 110 if (const auto named = findByName(value.name); named && named->id != value.id) {
134
1/3
✗ Branch 47 → 48 not taken.
✓ Branch 47 → 49 taken 2 times.
✗ Branch 48 → 49 not taken.
 2 if (!value.id.isEmpty()) remove(value.id);
135 2 value.id = named->id;
136 110 }
137
4/4
✓ Branch 52 → 53 taken 110 times.
✓ Branch 53 → 54 taken 110 times.
✓ Branch 65 → 55 taken 5057 times.
✓ Branch 65 → 66 taken 108 times.
 5165 for (MailTemplate &existing : m_templates) {
138
2/2
✓ Branch 57 → 58 taken 5055 times.
✓ Branch 57 → 59 taken 2 times.
 5057 if (existing.id != value.id) continue;
139 2 existing = value;
140
1/1
✓ Branch 60 → 61 taken 2 times.
 2 sort();
141 2 return value;
142 }
143
2/2
✓ Branch 67 → 68 taken 1 time.
✓ Branch 67 → 77 taken 107 times.
 108 if (m_templates.size() >= MaxTemplates) {
144
1/2
✓ Branch 68 → 69 taken 1 time.
✗ Branch 68 → 76 not taken.
 2 if (error) *error = QStringLiteral("count");
145 1 return std::nullopt;
146 }
147
3/4
✓ Branch 78 → 79 taken 107 times.
✗ Branch 78 → 84 not taken.
✓ Branch 79 → 80 taken 107 times.
✓ Branch 80 → 81 taken 107 times.
 107 if (value.id.isEmpty()) value.id = QUuid::createUuid().toString(QUuid::WithoutBraces);
148 107 m_templates.append(value);
149 107 sort();
150 107 return value;
151 }
152
153 3 bool TemplateStore::rename(const QString &id, const QString &name, QString *error) {
154
1/1
✓ Branch 2 → 3 taken 3 times.
 3 const QString trimmed = name.trimmed();
155
2/3
✓ Branch 3 → 4 taken 3 times.
✗ Branch 4 → 5 not taken.
✓ Branch 4 → 14 taken 3 times.
 3 if (!validName(trimmed)) {
156 ✗ if (error) *error = QStringLiteral("name");
157 ✗ return false;
158 }
159
6/7
✓ Branch 14 → 15 taken 3 times.
✓ Branch 16 → 17 taken 1 time.
✓ Branch 16 → 21 taken 2 times.
✓ Branch 19 → 20 taken 1 time.
✗ Branch 19 → 21 not taken.
✓ Branch 22 → 23 taken 1 time.
✓ Branch 22 → 32 taken 2 times.
 3 if (const auto named = findByName(trimmed); named && named->id != id) {
160
1/2
✓ Branch 23 → 24 taken 1 time.
✗ Branch 23 → 31 not taken.
 2 if (error) *error = QStringLiteral("taken");
161 1 return false;
162 3 }
163
3/4
✓ Branch 36 → 38 taken 2 times.
✓ Branch 38 → 39 taken 2 times.
✓ Branch 49 → 40 taken 3 times.
✗ Branch 49 → 50 not taken.
 3 for (MailTemplate &existing : m_templates) {
164
2/2
✓ Branch 42 → 43 taken 1 time.
✓ Branch 42 → 44 taken 2 times.
 3 if (existing.id != id) continue;
165 2 existing.name = trimmed;
166
1/1
✓ Branch 45 → 46 taken 2 times.
 2 sort();
167 2 return true;
168 }
169 ✗ if (error) *error = QStringLiteral("missing");
170 ✗ return false;
171 3 }
172
173 3 bool TemplateStore::remove(const QString &id) {
174 8 return m_templates.removeIf([&id](const MailTemplate &value) { return value.id == id; }) > 0;
175 }
176
177 116 void TemplateStore::sort() {
178 116 std::stable_sort(m_templates.begin(), m_templates.end(), [](const MailTemplate &a, const MailTemplate &b) {
179 18703 return a.name.compare(b.name, Qt::CaseInsensitive) < 0;
180 });
181 116 }
182